#75 Small mistake in frontmatter xform

None
pending-remind
nobody
None
5
2013-07-12
2010-05-12
Berend
No

DocTitle does not apply when there is a decoration in the tree. The proper test is there, but there's a typo or an surpluss condititional i think..

DocTtitle's apply() bails out when candidate_index() is none.
node.first_child_not_matching_class gives that index, which is none or an index within the bounds of the node.

So the test

len(node) > (index + 1)

can go I'd think (see patch). And otherwise it should be

len(node) <= (index + 1)

Discussion

  • Berend
    Berend
    2010-05-12

    Remove conditional

     
    Attachments
  • Günter Milde
    Günter Milde
    2011-06-07

    Unfortunately, the author of the relevant code is no loger active.
    Could you provide a test that fails wihtout but works with the patch
    (Patch to the Docutils test suite and/or example document)?

     
  • Günter Milde
    Günter Milde
    2013-07-12

    • status: open --> pending-remind
    • Group: --> None