From: SourceForge.net <no...@so...> - 2010-03-03 13:59:09
|
Patches item #2962627, was opened at 2010-03-03 08:59 Message generated for change (Tracker Item Submitted) made by timehorse You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422032&aid=2962627&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) Assigned to: Nobody/Anonymous (nobody) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422032&aid=2962627&group_id=38414 |
From: SourceForge.net <no...@so...> - 2010-03-18 13:30:28
|
Bugs item #2972588, was opened at 2010-03-18 09:30 Message generated for change (Tracker Item Submitted) made by timehorse You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: emacs mode Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) Assigned to: Nobody/Anonymous (nobody) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 |
From: SourceForge.net <no...@so...> - 2010-03-18 13:33:24
|
Patches item #2962627, was opened at 2010-03-03 08:59 Message generated for change (Settings changed) made by timehorse You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422032&aid=2962627&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Deleted >Resolution: Duplicate Priority: 5 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) Assigned to: Nobody/Anonymous (nobody) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- >Comment By: Jeffrey C. Jacobs (timehorse) Date: 2010-03-18 09:33 Message: Moved to bug # 2972588 since this patch fixes the described bug rather than being generic. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422032&aid=2962627&group_id=38414 |
From: SourceForge.net <no...@so...> - 2010-03-31 08:28:39
|
Bugs item #2972588, was opened at 2010-03-18 13:30 Message generated for change (Settings changed) made by milde You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: emacs mode Group: None Status: Open Resolution: None >Priority: 2 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) Assigned to: Nobody/Anonymous (nobody) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 |
From: SourceForge.net <no...@so...> - 2010-08-18 11:47:33
|
Bugs item #2972588, was opened at 2010-03-18 09:30 Message generated for change (Comment added) made by timehorse You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: emacs mode Group: None Status: Open Resolution: None Priority: 2 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) Assigned to: Nobody/Anonymous (nobody) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- >Comment By: Jeffrey C. Jacobs (timehorse) Date: 2010-08-18 07:47 Message: Since some of the rst.el issues have recently been fixed, would anyone be ready to review this issue, the proposed solution and its test cases? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 |
From: SourceForge.net <no...@so...> - 2010-08-18 21:22:41
|
Bugs item #2972588, was opened at 2010-03-18 14:30 Message generated for change (Settings changed) made by smerten You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: emacs mode Group: None Status: Open >Resolution: Accepted Priority: 2 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) >Assigned to: Stefan Merten (smerten) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- >Comment By: Stefan Merten (smerten) Date: 2010-08-18 23:22 Message: I'll care about most about issues in rst.el. However, I'll start with fontification stuff (since this is my code). The topic you are raising might be fixed like you proposed. However, the deeper issue is that the whole code should be refactored to integrate stuff from font-locking with the stuff from Martin Blais. Well, a quick fix is more probable ;-) . ---------------------------------------------------------------------- Comment By: Jeffrey C. Jacobs (timehorse) Date: 2010-08-18 13:47 Message: Since some of the rst.el issues have recently been fixed, would anyone be ready to review this issue, the proposed solution and its test cases? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 |
From: SourceForge.net <no...@so...> - 2010-12-22 19:53:15
|
Bugs item #2972588, was opened at 2010-03-18 14:30 Message generated for change (Comment added) made by smerten You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: emacs mode Group: None >Status: Closed >Resolution: Fixed Priority: 2 Private: No Submitted By: Jeffrey C. Jacobs (timehorse) Assigned to: Stefan Merten (smerten) Summary: The rst-adjust function in rst.el misinterprets comments Initial Comment: The rst-adjust function in rst.el misinterprets comments as section headings. The attached patch file, diffed against the /trunk/docutils/tools/editors/emacs/rst directory of the repository, provides a test case illustrating the issue and a solution. Basically, the current emacs script interprets comments following text or directives as a section mark-up when this is actually a comment. Any line consisting of 2 dots followed by 0 or more white-space should be considered a comment and not a form of mark-up. The quintessential example is the use of a parameterized contents directive with the rst-toc-update command to populate the TOC in the document as a comment, which is the example given in the test case: ============== Document Title ============== Subtitle ======== .. contents:: :depth: 2 .. 1 Section 1 2 Section 2 Section 1@ --------- Section 2 --------- One would expect a rst-adjust command executed at the specified cursor position to promote Section 1 to the same level as Subtitle. Instead, in the current code, it promotes it to ..... underscore, which is not in this document. Again, the given patch corrects this by excluding lines of the form \\.\\.[ \t]*$ from the search for section headings in rst-line-homogeneous-p. I am assuming this will not affect existing documents because I believe the case of comment following text or directive to be rare but that this patch should bring the emacs mode more in line with what how the docutils actually interprets the given text. ---------------------------------------------------------------------- >Comment By: Stefan Merten (smerten) Date: 2010-12-22 20:53 Message: Fixed in r6506. ---------------------------------------------------------------------- Comment By: Stefan Merten (smerten) Date: 2010-12-22 20:53 Message: Fixed; thanks for the bug report. You can download a current snapshot from: http://docutils.sf.net/docutils-snapshot.tgz ---------------------------------------------------------------------- Comment By: Stefan Merten (smerten) Date: 2010-08-18 23:22 Message: I'll care about most about issues in rst.el. However, I'll start with fontification stuff (since this is my code). The topic you are raising might be fixed like you proposed. However, the deeper issue is that the whole code should be refactored to integrate stuff from font-locking with the stuff from Martin Blais. Well, a quick fix is more probable ;-) . ---------------------------------------------------------------------- Comment By: Jeffrey C. Jacobs (timehorse) Date: 2010-08-18 13:47 Message: Since some of the rst.el issues have recently been fixed, would anyone be ready to review this issue, the proposed solution and its test cases? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=422030&aid=2972588&group_id=38414 |