#631 rowsep lines after last row of a table

output: all formats
closed-fixed
XSL (1066)
5
2005-05-17
2005-03-30
Tom (flaute)
No

If a table has rowsep=1 (default), then when an entry
has @morerows attribute such that it occupies also the
remaining rows (i.e., a vertical span to the bottom of the
table), it will have rowsep=1 (internally), so it will be
drawn a rowsep line below this entry (if
$table.borders.with.css=1).
This contradicts the DocBook specs, which says that
the lines after the last rows/columns are to be controlled
with the @frame attribute of the table.

This bug can be easily eliminated, see attached diff file
on xhtml/table.xsl of the docbook-xsl-1.68.1 distribution.

Also attached the example xml and output xhtml files,
and an xsl file (to be put in the xhtml dir; this only
imports docbook.xsl and sets table.border.with.css=1).

Discussion

  • Tom (flaute)
    Tom (flaute)
    2005-03-30

    Example test xml

     
  • Tom (flaute)
    Tom (flaute)
    2005-03-30

    Example output

     
  • Tom (flaute)
    Tom (flaute)
    2005-03-30

    docbook xsl with table.borders.with.css=1

     
  • Tom (flaute)
    Tom (flaute)
    2005-03-30

    diff on xhtml/table.xsl (3 more lines to $rowsep of entry match)

     
    Attachments
  • Tom (flaute)
    Tom (flaute)
    2005-04-02

    • milestone: 447634 --> output: all formats
     
  • Tom (flaute)
    Tom (flaute)
    2005-04-02

    Logged In: YES
    user_id=1244561

    it seems that it's not only an (x)html output problem, so
    changed the group spec.

     
  • Robert Stayton
    Robert Stayton
    2005-05-13

    Logged In: YES
    user_id=193218

    A fix for this issue has been added to the current codebase.
    Please test the fix with the latest snapshot from:

    http://docbook.sourceforge.net/snapshots/

     
  • Robert Stayton
    Robert Stayton
    2005-05-13

    • assigned_to: nobody --> bobstayton
    • status: open --> closed-fixed
     
  • Tom (flaute)
    Tom (flaute)
    2005-05-16

    • status: closed-fixed --> open-fixed
     
  • Tom (flaute)
    Tom (flaute)
    2005-05-16

    Logged In: YES
    user_id=1244561

    Since I didn't found any changes regarding this issue in the
    codebase snapshot (nor in xhtml/table.xsl either in
    html/table.xsl) - assuming a fault in the fixing workflow or just
    an erroneous entry by bob - I reopened this issue.

     
  • Tom (flaute)
    Tom (flaute)
    2005-05-16

    • summary: rowsep lines after last row of a table --> rowsep line below the last row of a table
     
  • Robert Stayton
    Robert Stayton
    2005-05-16

    • summary: rowsep line below the last row of a table --> rowsep lines after last row of a table
    • status: open-fixed --> pending-fixed
     
  • Robert Stayton
    Robert Stayton
    2005-05-16

    Logged In: YES
    user_id=193218

    Ack, my CVS checkin didn't make it. It is checked in now,
    and the patch is in the latest XSL snapshot version. I'll leave
    it at Pending until I hear that is working.

     
  • Tom (flaute)
    Tom (flaute)
    2005-05-17

    • status: pending-fixed --> open-fixed
     
  • Tom (flaute)
    Tom (flaute)
    2005-05-17

    Logged In: YES
    user_id=1244561

    Checked and it seems that it's working (hopefully with no
    side-effect - actually tested the patch before). Thank you!

     
  • Robert Stayton
    Robert Stayton
    2005-05-17

    • status: open-fixed --> closed-fixed