Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#8 diffheader support

v2.3.0
closed-fixed
3
2007-10-13
2007-10-10
Daniel Black
No

diffheader needs TRE_APPROX defined

Discussion

  • Daniel Black
    Daniel Black
    2007-10-10

    Logged In: YES
    user_id=612034
    Originator: YES

    path for include maybe should be /usr/local/include/tre by default as that's where tre installs it by default.

    if this isn't added people may get a compile fault is /usr/include/regex.h is included with glibc

    alternately make the include <regex.h> to include <tre/regex.h>

     
    • labels: --> Functionality
    • milestone: --> v2.3.0
    • priority: 5 --> 3
    • assigned_to: nobody --> sm-msk
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    TRE_APPROX is defined by <tre-config.h>, which is included by the <regex.h> from the Tre package. Thus, if you include the right <regex.h>, you get that defined, so putting it in site.config.m4.sample isn't the right thing to do

    In site.config.m4.sample there are places to add the include path to find Tre's <regex.h> if it's not the standard location. I will update those to use /usr/local/{include,lib}/tre by default.

     
  • Daniel Black
    Daniel Black
    2007-10-10

    Logged In: YES
    user_id=612034
    Originator: YES

    quite right - I added the TRE_APPROX before I was including the right regex.h. Thanks.

     
  • Todd A. Lyons
    Todd A. Lyons
    2007-10-12

    Logged In: YES
    user_id=23785
    Originator: NO

    I found it easiest to add to libdkim/dkim.c:

    #ifdef _FFR_DIFFHEADERS
    #include "tre/regex.h"
    #endif /* _FFR_DIFFHEADERS */

    Is it safe to assume that your preference is to modify the m4 files to search in different include locations or a different order instead of being more specific when including the regex functions?

     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Can you safely include both regex.h and tre/regex.h?

    At any rate, the right thing to do is adjust the include paths. This is done in site.config.m4.sample in the patched release.

    2.3.1 is now available with this patch.

     
    • status: open --> closed-fixed