#17 make sender-pattern in keylist file case-insensitive

v2.1.2
closed-accepted
3
2007-08-31
2007-08-28
lbolmerg
No

the sender_pattern in the KeyList file should be case-insensitive. If email senders use capital letters to beautify their email addresses these addresses might not be caught by sender_pattern specified in KeyFile

Discussion

  • Logged In: YES
    user_id=1048957
    Originator: NO

    To be precise about a solution here in terms of the relevant RFCs, it's actually necessary to be case-sensitive in the local-part (before the "@") and case-insensitive in the hostname (after the "@").

    However I'm willing to bet there aren't many cases in the real world where, for example, "root" and "Root" are different users.

    I'll attach a patch for you to try later this morning.

     
    • milestone: --> v2.1.2
    • priority: 5 --> 3
    • assigned_to: nobody --> sm-msk
     
  • lbolmerg
    lbolmerg
    2007-08-28

    Logged In: YES
    user_id=1754044
    Originator: YES

    Thanks, I would appreciate a patch. To be case sensitive in the local part is absolutely fine. The part after the '@' is my concern.
    FYI: I am currently using version 2.0.1 installed from the FreeBSD ports tree. Would I need to upgrade to the latest version to apply the patch?

     
  • Proposed patch #1

     
    Attachments
  • Logged In: YES
    user_id=1048957
    Originator: NO

    The patch (attached) is against the most recent source but should still apply with reasonable munging options to the patch command. Even if not, it's a one-line change so you can apply it manually and try it yourself if the patch command complains too much.
    File Added: PATCH

     
  • lbolmerg
    lbolmerg
    2007-08-29

    Logged In: YES
    user_id=1754044
    Originator: YES

    Thanks for the patch. Works fine. Will the patch be included in the next release?

     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Yes. I currently have no target date set for a new release, but given the other changes made recently I might do one either late tomorrow or soon after the long weekend.

     
    • status: open --> closed-accepted
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    v2.2.0 released, containing this patch.