Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#89 Improve handling of space-before-colon headers

v2.3.2
closed-fixed
5
2007-11-30
2007-11-15
No

If a message comes in with a signature containing:

h=...:Date:...

...and a header containing:

Date : ...

...then that Date header is not replayed into canonicalization. Internally the header is stored exactly as-is and thus a direct string comparison match will fail when searching for headers to canonicalize.

Although DKIM is predicated on the message being properly formed, this is a case consensus feels should be handled by the implementation.

Discussion

  • Logged In: YES
    user_id=1048957
    Originator: YES

    Try the attached patch.
    File Added: PATCH

     
  • Logged In: YES
    user_id=1048957
    Originator: YES

    A more complete patch.
    File Added: PATCH

     
  • Proposed patch #2

     
    Attachments
    • status: open --> closed
     
  • Logged In: YES
    user_id=1048957
    Originator: YES

    v2.4.0 released, containing this patch.

     
    • status: closed --> closed-fixed