Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#88 dkim_policy() incorrect use of CBSTAT_TRYAGAIN

v2.3.2
closed-fixed
5
2007-12-20
2007-11-02
Chris Behrens
No

dkim_policy() is not keeping state for re-entry when using a policy_lookup callback that returns TRYAGAIN. dkim_policy() will re-request a policy record for which it has already received a result... double elimination.

Discussion

    • assigned_to: nobody --> sm-msk
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    A state variable should fix this. Then the re-execution of dkim_policy() can just skip to where it left off.

    Target for 2.4.1.

     
  • Chris Behrens
    Chris Behrens
    2007-11-02

    dkim-policy-state.patch

     
  • Chris Behrens
    Chris Behrens
    2007-11-02

    Logged In: YES
    user_id=627199
    Originator: YES

    Attaching a patch that seems to work. I also added a new function dkim_restart_policy() which could be used to restart policy checking from the beginning, basically resetting state to the starting state. Didn't include docs for that, and I don't know what you might want for a proper name for this.
    File Added: dkim-policy-state.patch

     
    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    A different way of making dkim_policy() re-entrant has been included in 2.4.1, now released.