Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#68 dkim_header() check for signature header is wrong

v2.3.2
closed-fixed
5
2007-11-30
2007-10-24
Chris Behrens
No

The check at the end of dkim_header() for match against DKIM_SIGNHEADER checks for colon in 'hdr', which is always true. Thus, the strncasecmp() there can match any header like:

D:
DK:
DKI:

Instead, the hdr length should be checked to make sure it is the same length as DKIM_SIGNHEADER..

Patch attached.

Discussion

  • Chris Behrens
    Chris Behrens
    2007-10-24

    dkim_header.diff

     
    Attachments
    • assigned_to: nobody --> sm-msk
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Patch applied for next release.

     
    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    v2.4.0 released.