#62 valgrind messages

v2.2.1
closed
Other (4)
3
2007-09-21
2007-09-19
sid_milter_user
No

valgrind outputs the attached messages for dkim-milter-2.2.1 with patch #1796697 and openssl-0.9.8e on CentOS 5 (x86_64).

Discussion

  •  
    Attachments
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Almost all of those complain about problems inside OpenSSL (unless I'm failing to call some startup function in their API that I don't know about).

    The ones that refer to libdkim/base64.c are confusing. It claims "Use of uninitialised value of size 8" on a line like this:

    buf[n++] = alphabet[(bits >> 6) & 0x3f];

    "buf" is being updated, so its current content is not used (and an element of "buf" is of size 1 anyway so that can't be what it's talking about); "alphabet" is a constant string so clearly it has been initialized (and again, an element of it is of size 1); "n" is initialized at 158 and "bits" is initialized at line 156, so I don't understand why it's complaining.

     
    • priority: 5 --> 3
    • assigned_to: nobody --> sm-msk
     
    • labels: --> Other
    • milestone: --> v2.2.1
    • status: open --> pending
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Internal code review also verifies that these complaints appear to be false or at least outside the purview of dkim-filter's source code.

     
    • status: pending --> closed
     
  • Logged In: YES
    user_id=1893970
    Originator: YES

    Thank you for the comments. I am sorry for having reported the false positive valgrind messages.