#40 recent fix reports syntax error for messages missing the sig

v0.4.1
closed-fixed
5
2007-03-13
2006-08-17
Sergiy Zhuk
No

The following change was introduced in 0.4.1:
LIBDK: In dk_eom(), return DK_STAT_SYNTAX if
dk_skipbody is set.
Failing to do so means a message with a signature header
below which there is no sender header will report a bogus
success status. Problem noted by Lennert Buytenhek.

As a side effect this makes it report a syntax error for
messages which are not signed at all, e.g. domain key
signature is not present in the message.
Allowing those messages thru w/o reporting syntax error
like it was before or reporting 'no signature data' would
be a much better way to handle this.

thanks

Discussion

  • Sergiy Zhuk
    Sergiy Zhuk
    2006-08-17

    Logged In: YES
    user_id=1577689

    here's a patch restoring prev. behavior just in case

     
  • Sergiy Zhuk
    Sergiy Zhuk
    2006-08-17

     
    Attachments
  • blentz
    blentz
    2006-10-27

    Logged In: YES
    user_id=997838

    Thanks for that reversal patch... I had 141,362 of these
    messages in this week's maillog as a result of senders with
    no DomainKey-Signature.

     
    • assigned_to: nobody --> sm-msk
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Unfortunately the old behaviour isn't correct either. I'll have to come up with a better solution.

     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Looks like I already had a patch for this which was never released. It will be in 0.4.2.

     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    v0.4.2 released.

     
    • status: open --> closed-fixed