#132 wx: Save and load spumode and audiodriver

Latest SVN
closed-out-of-date
nobody
None
5
2013-10-03
2011-07-04
Jan Bücken
No

This patchset provides the framework to save and load the spumode and the audiodriver to/from the wxconfigfile.

But they are based on the patches in "3301520 wx port - Add windows like toolbar".
Thus you need to apply the "N00*" patchset first, then this patchset.

Discussion

  • Jan Bücken
    Jan Bücken
    2011-07-04

    One offtopic comment to prevent a bug:
    After my spumode and audiodriver patch you generated a new variable in wxMain.cpp:

    #if defined(WIN32) || defined(HAVE_LIBSOUNDTOUCH)
    #define HAVE_SPUMODE_SYNCP
    #endif

    but in wxMain.h you use

    #ifdef HAVE_LIBSOUNDTOUCH
    wSPUMODE_SYNCP,
    #endif

    only. I believe this could be a problem. This needs an "or" for WIN32, too. Otherwise wSPUMODE_SYNCP is not defined in wxMain.cpp. Or I'm wrong.

     
  • Jan Bücken
    Jan Bücken
    2011-07-04

    And a topic comment:

    At the moment we enumerate the audiodriver like this in wxMain.cpp:

    enum audiodriver_enum {
    AUDIODRIVER_SDL = 0,
    AUDIODRIVER_DISABLE
    };

    But usually "0" is disabled. We may change the numeration to

    enum audiodriver_enum {
    AUDIODRIVER_DISABLE = 0,
    AUDIODRIVER_SDL
    };

    In this case the entry in the wxconfigfile desmume.ini is more intuitively.

     
  • zeromus
    zeromus
    2013-10-03

    • status: open --> closed-out-of-date
    • Group: --> Latest SVN