#129 Need to support the PCSX-2 Synchronizer in the Cocoa port

closed-fixed
None
5
2011-06-20
2011-06-18
rogerman
No

The next Cocoa port release will be exposing SPU synchronizer functionality to the user. This patch allows compilation of the necessary PCSX-2 Synchronizer code for the Cocoa port.

Discussion

1 2 > >> (Page 1 of 2)
  • Can't you define HAVE_LIBSOUNDTOUCH instead?

     
    • assigned_to: nobody --> riccardom
     
  • rogerman
    rogerman
    2011-06-18

    I would strongly prefer not to just define HAVE_LIBSOUNDTOUCH for metaspu.cpp, because this will change the #include paths in Timestretcher.cpp.

    From Timestretcher.cpp --

    #ifdef HAVE_LIBSOUNDTOUCH
    #include <SoundTouch.h>
    #else
    #include "SoundTouch/SoundTouch.h"
    #endif

    The reason why I didn't define HAVE_LIBSOUNDTOUCH is because it is kind of a misnomer -- all ports will have it because the entire library is included with DeSmuME.

    The bit in Timestretcher.cpp using an external vs internal SoundTouch library confuses me. I'd assume that all ports should be using the one included with DeSmuME. I thought that, as a general case, it would be better to use the included library instead of an external one, since there's probably some reason why it's in there.

     
  • It depends on the platform on *nix we usually prefer to use system libraries and shipping private copies of libraries is considered bad practice. It looks like your plan is to use the shipped one instead, I'll apply your patch then.

     
  • rogerman
    rogerman
    2011-06-18

    Sure thing about the system libraries issue. ;-D

    Yeah, I'm using the shipped library because I think that is the safer route. I honestly don't know if there are any DeSmuME-specific changes to that code, or possibly any future planned changes.

     
  • rogerman
    rogerman
    2011-06-18

    Sure thing about the system libraries issue. ;-D

    Yeah, I'm using the shipped library because I think that is the safer route. I honestly don't know if there are any DeSmuME-specific changes to that code, or possibly any future planned changes.

     
  • zeromus
    zeromus
    2011-06-18

    i dont know if its modified either. are you eager to find out?

     
    • status: open --> closed-fixed
     
  • Applied, thanks. The patch did not apply though even after converting with dos2unix. How do you diff?

     
1 2 > >> (Page 1 of 2)