Menu

#425 Saving mixer name

open
Sound (58)
5
2009-09-08
2009-09-07
No

Hi, I've been debugging this thing and it turns out that the mixer names are limited to 30 characters, then with Vista mixer names aren't what they used to be, bottom line is that the mixer "Line in" on my computer, ends with " " when it is trimmed to 30 chars, so the funny thing is that in the ini file the name is saved, but when it is read back the last " " is not loaded, so it looks like DScaler can't remember my mixer, the real problem arises on FindMixerLine when it compares the string they don't match because of the trailing space. I have made this function return 2 (the value that it should return on my PC) and got it working, now that of course is not a practical fix, so I think I can try to fix it but I would like a little guidance on how to do it, I mean, where to touch to fix this? on the FindMixerLine? when the Mixers are enumerated? so it will never end with the " "? Let me know your opinion and I will try to come with a patch.

Discussion

  • John Adcock

    John Adcock - 2009-09-08

    Guillermo

    Thanks for the report, the best way out of this I think is to implement and then use the Trim function in StringHelpers, then we just need to Trim both sides before a comparison, we should probably make th comparion case insenstive as well.

    Cheers

    John

     
  • John Adcock

    John Adcock - 2009-09-08
    • assigned_to: nobody --> adcockj
     
  • Nobody/Anonymous

    I have a patch for this, trimming white space on the CMixer constructor. However I don't know how to post the patch (I created a (.patch) file with tortoise) Let me know if you'd like to check it out.

     
  • Guillermo Ruffino

    I wasn't logged in, now I fugured it out. :)

     

Log in to post a comment.