From: Jacek S. <arn...@gm...> - 2008-03-27 19:42:39
|
Hi, Thanks for the patch, but there are a few errors. First off, it seems that the bzr patch you sent is empty - I think you need to commit your changes locally (which is the default if you used "bzr branch") before doing "bzr send" - it gives the diff between the branch source and your commit, not what you have in your working tree. bzr diff will produce a diff against the working tree, but it won't include information about which revision you started from so a "bzr send" is preferable - I'm not very good with bzr though so I'm not sure - any form will be fine. Second, you didn't add the setting to the strings in settingsmanager.cpp so it won't actually be loaded/saved. Third you can use a reference here: "TTHValue t = aResult->getTTH();" becomse "const TTHValue& t = aResult->getTTH();"... Regards, /J Smir wrote: >> Hi, >> >> Sorry for taking a while...I'd like to see this option too, but optional...so >> could you please add a >> boolean setting for it? >> >> Regards >> /Jacek >> >> dcp...@sm... wrote: >>> Hi, >>> >>> I created a patch which will filter files from the search results, if they >> are >>> already in your own share (with same TTH). >>> It works well for me and I think others might like it, too. >>> >>> Bye, >>> Smir > > > Now it is available as option in the Search Frame. > > I created the patch file with "bzr send -o filtershared.patch", but I am not > sure if it can be used, because it is somehow encrypted :P > That's why I also send the diff. > > I also have a question: How do I get a smaller filesize when compiling? > I use "scons mode=release" and always have an executable which is about 100 MB. > But the official release is only ~2MB... > > Bye, > Smir > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > dcplusplus-devel mailing list > dcp...@li... > https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel |