From: SourceForge.net <no...@so...> - 2008-02-29 21:19:58
|
Bugs item #1710743, was opened at 2007-05-01 18:31 Message generated for change (Settings changed) made by rlogiacco You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=449491&aid=1710743&group_id=47439 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Will Sargent (wsargent) Assigned to: Nobody/Anonymous (nobody) Summary: DataSourceDatabaseTest does not use setSchema() Initial Comment: The DataSourceDatabaseTester class uses public IDatabaseConnection getConnection() throws Exception { Assert.assertNotNull( "DataSource is not set", dataSource ); return new DatabaseConnection( dataSource.getConnection() ); } even when the schema has been set. It should use return new DatabaseConnection(dataSource.getConnection(), getSchema()); ---------------------------------------------------------------------- Comment By: Roberto Lo Giacco (rlogiacco) Date: 2008-02-18 14:23 Message: Logged In: YES user_id=57511 Originator: NO Can you detail the bug this patch solves? ---------------------------------------------------------------------- Comment By: aalmiray (aalmiray) Date: 2007-05-03 13:27 Message: Logged In: YES user_id=1192026 Originator: NO I've created a patch for DataSourceDatabaseTester and JndiDatabaseTester but I'm not getting an option to attach files on this thread, so I'm adding it to this message. -------- START OF PATCH -------- Index: trunk/src/java/org/dbunit/DataSourceDatabaseTester.java =================================================================== --- trunk/src/java/org/dbunit/DataSourceDatabaseTester.java (revision 552) +++ trunk/src/java/org/dbunit/DataSourceDatabaseTester.java (working copy) @@ -50,6 +50,10 @@ public IDatabaseConnection getConnection() throws Exception { Assert.assertNotNull( "DataSource is not set", dataSource ); - return new DatabaseConnection( dataSource.getConnection() ); + if( getSchema() != null ){ + return new DatabaseConnection( dataSource.getConnection(), getSchema() ); + }else{ + return new DatabaseConnection( dataSource.getConnection() ); + } } } Index: trunk/src/java/org/dbunit/JndiDatabaseTester.java =================================================================== --- trunk/src/java/org/dbunit/JndiDatabaseTester.java (revision 552) +++ trunk/src/java/org/dbunit/JndiDatabaseTester.java (working copy) @@ -66,7 +66,11 @@ initialize(); } - return new DatabaseConnection( dataSource.getConnection() ); + if( getSchema() != null ){ + return new DatabaseConnection( dataSource.getConnection(), getSchema() ); + }else{ + return new DatabaseConnection( dataSource.getConnection() ); + } } /** -------- END OF PATCH -------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=449491&aid=1710743&group_id=47439 |