From: Werner Baumann <werner.baumann@on...> - 2005-04-23 11:25:12
Hello to everyone,
Sung invited me to join the project and I hope this is the appropriate
list for discussions with the developers.
So I may shortly introduce myself: I am old (55 of age) and at time
working as sort of freelancer in the vocational training business
(mainly IT/networking but also electronics).
My motiviation to do this patch was mainly to achieve simple mount and
unmount as normal user. But as I am not very familiar with this kind of
C-programming, I often got confused and wished to get the start-up code
looking more straight forward.
Now I noticed, you plan a new release soon. I strongly agree, that it
would not be a good idea to insert my patch (or most of it) into this
release, because it needs review, discussion and last but not least testing.
Some questions concerning my patch and bugs in my patch:
1. It was a bad idea to put the code for interactively asking
credidentials into the call-back-function in webdav.c, because this
might be called when we are in daemon mode. Sung did a work-around for
this. But as interactivity is only possible at start up before forking,
I would prefer to move this code into util.c. I wrote a function
ask_auth() that is called from get_args(). The auth-call-back-function
would be reduced to copying from a global variable to neon.
2. Sung reported this error:
[hunkim@... davfs2]$ mount /dav/hunkim.dforge/
/sbin/mount.davfs: Could not open pid-file
This is related to file-ownership and permissions. For usermount normal
users need permission to write pid-files and to read/write to the
device-file. I have made the directory /var/run/davfs2 root.users 1775.
But the group 'users' is not much in use today, so in most cases the
admin has to put every davfs2-user there. But I think there is no clean
way to avoid this. The device-special-files should belong to the same
group and have write permissions for the group (not the way I do it
now). But which group to choose for this (Often there used special
groups like disk, cdrom or audio in cases like this)? I would prefer
'users' as default, but make it a compile time option, so distributors
can adjust according to their policy.
3. Sung decided not to delete the args-structure becouse its contents
may be used later. I also noticed that there is some duplicating from
args (or mountopts) to global variables. So it might be a good idea to
make the structure args a global variable and to avoid some of the
Question for help:
I needed some new macros in the makefile that are evaluated by
configure, and that I also need to use in the C-code (e.g. SYSCONFDIR).
To achive this I added them to CFLAGS. By isn't there a better solution,
for example to get them into config.h?
Sorry for the lot of text, but it is my first email to all of you. Next
email will be a short one.