#131 ViewSourceWith adds carriage returns

closed-invalid
Davide Ficano
5
2011-08-17
2011-08-16
bart
No

The ViewSourceWith extension adds carriage returns in any text that has been edited even if the editor itself consistently uses newlines. That behavior makes it impossible to use this extension to submit kernel patches. For more information, see also http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=commitdiff;h=5ce9f07bf1bed9a1f9886373ad0b149294f84c25.

Discussion

  • Davide Ficano
    Davide Ficano
    2011-08-17

    Editing plain text VSW never adds extra NL/CR at least on my env (Linux + FF and Snow Leopard + FF).

    Editing rich text (e.g. HTML content from gmail) the HTML arriving from the page in some cases already contains extra <BR/> tags not added by VSW, this seems a bug related to Firefox

    Another problem editing plain text files occurs when you use VI or VIM, it adds always a strange 000a byte sequence at end when you save

    You can simply check yourself, using the hexdump utility

    0000120 6c65 6f6c 000a

    Other editors (I use KomodoEdit on Linux) don't add any extra trail characters.

    VSW doesn't do anything to text, it saves from the text box and then loads the file without processing or modifying the text

    Please tell me better if you edit plain or rich text and what editor you use, please verify that the saved file doesn't contain strange chars using hex dumping utilities

    If necessary I can try to remove "strange" sequences from the text but when I must consider them "strange"?

     
  • bart
    bart
    2011-08-17

    A closer look at this issue revealed that the unwanted behavior is caused by gmail and not by ViewSourceWith, so I'm closing this bug report. Sorry for the noise.

     
  • bart
    bart
    2011-08-17

    • status: open --> closed-invalid