#103 Improved handling of ListView refresh and re-sort

WinCvs
closed-fixed
WinCvs (90)
5
2005-04-03
2005-03-20
Kirill Müller
No

When changing the sort order of the ListView, the item that
is currently visible may become invisible. This is because
no repositioning of the ListView is done during the re-sort.

On ListView refresh, the position of the horizontal scroll bar
is reset. This is unwanted in most cases.

This patch addresses both issues.

The patch is made from the main trunk. Please feel free to
use it.

Discussion

  • Kirill Müller
    Kirill Müller
    2005-03-20

    Logged In: YES
    user_id=1241036

    The horizontal scroll bar position is reset incorrectly if the scroll
    bar is in the "right half". I'll have a look at that problem.

     
  • Kirill Müller
    Kirill Müller
    2005-03-20

    Logged In: YES
    user_id=1241036

    Just found a solution. Everything should work fine now.

     
  • Oliver Giesen
    Oliver Giesen
    2005-03-22

    Logged In: YES
    user_id=158827

    Does this also address the issue where, when an operation
    removes the previously selected item from the currently
    active filter (e.g. when committing a file while the
    committable filter is turned on), the view scrolls back up
    to the first item?

     
  • Kirill Müller
    Kirill Müller
    2005-03-23

    Logged In: YES
    user_id=1241036

    No, not yet. I'll fix that.

     
  • Oliver Giesen
    Oliver Giesen
    2005-03-23

    Logged In: YES
    user_id=158827

    Great! :)

    Keep those patches coming! :)

     
  • Kirill Müller
    Kirill Müller
    2005-04-02

    Logged In: YES
    user_id=1241036

    As promised, here comes an extension for the list view refresh
    behaviour. The following rules are used:

    1. The first item in the list that was previously selected and visible
    remains on its position
    2. If no such item exists, the first item in the list that was
    previously deselected and visible remains on its position
    3. If no such item exists, the first selected item is shown in the
    first line of the list
    4. If no such item exists, the vertical position of the list remains
    unchanged

    Now, a refresh keeps the list as close as possible to the previous
    state even if no files were selected or if the previously selected
    file is removed from the list due to visibility filters.

    The updated files contain all issues from this thread.

     
  • Logged In: YES
    user_id=119527

    Sun Apr 03 2005 Jerzy Kaczorowski <kaczoroj@hotmail.
    com>
    * WinCvs 2.0.1:
    - #1167012 - Improved handling of ListView refresh and re-
    sort, patch by Kirill Mller <kirillmueller@users.sourceforge.
    net>

     
    • status: open --> closed-fixed