#102 Improved sort order for State column

WinCvs
closed-fixed
common (6)
3
2006-02-11
2005-03-20
Kirill Müller
No

The "State" column in the list view is sorted alphabetically.
This sort order doesn't reflect the "importance" of the state
in any way.

This patch addresses this issue. Now, the order for
the "State" column is the following:

CONFLICT
RESOLVED
MISSING
MODIFIED
REMOVED
UNKNOWN
IGNORED
<empty state>

Now, when flat view is enabled and the items are ordered
by "State", the most important items are on top. Personally,
I like this view best since it reflects best the current
modifications in a project.

The patch is made for the main trunk. Please feel free to
use it.

Discussion

  • Kirill Müller
    Kirill Müller
    2005-03-20

    • priority: 5 --> 3
    • assigned_to: nobody --> jerzyk
     
  • Kirill Müller
    Kirill Müller
    2005-03-21

     
    Attachments
  • Kirill Müller
    Kirill Müller
    2005-03-21

    Logged In: YES
    user_id=1241036

    The first version of the patch didn't work for structured (non-flat)
    ListView mode. This version should work well now.

     
  • Oliver Giesen
    Oliver Giesen
    2005-03-22

    Logged In: YES
    user_id=158827

    While we're at it: Does anyone know why we don't have a
    state for "Added"? Taking this into account here's my
    slightly adjusted suggestion for the "importance" ordering:

    Conflict
    Resolving
    Missing
    Modified
    Removed
    Added
    <empty state>
    Unknown
    Ignored

    I moved the <empty state> (i.e. regular CVS-controlled
    files) item up a bit as I would like to keep the non-CVS
    files clearly separated from the CVS-controlled files.

     
    • status: open --> open-postponed
     
  • Logged In: YES
    user_id=119527

    The problem is that different things are important to different
    people. I would change it to be:

    Missing <normally nothing should be missing>
    Conflict <needs to be resolved so it's important>
    Added <new state, not yet in the repo>
    Removed <Have to make sure it's the right thing to do>
    Unknown <should be either added or ignored>
    Ignored
    <empty> <non-empty ought to be on top always>

    I reality it's easier to use the toolbar filters to expose the state
    you're interested in.

    I am not sure whether it's good idea to to apply something like
    that, need to think about that.

     
  • Kirill Müller
    Kirill Müller
    2005-04-03

    Logged In: YES
    user_id=1241036

    Well, I'm sure that almost any sort order would be better than the
    alphabetical one... :-)

    Also thought about naming the states like "a-Missing", "b-
    Conflict", "c-Added", ..., thus preserving the alphabetical sort
    order _and_ the importance sort order. But that would look quite
    ugly, imho.

     
  • Kirill Müller
    Kirill Müller
    2006-02-10

    Logged In: YES
    user_id=1241036

    Well, I've been using this altered sort order for a little
    less than a year, combined with flat view. Don't know how
    to do without it, but that's everybody's own decision.
    (Also, I have never ever used the filter bar for the State
    column.)

    I'd vote to agree upon a sort order and to stick with that.
    I think that a GUI to configure the sort order would be
    overkill. Maybe a checkbox like "Use altered sort order for
    State column"?..

    My favorite is:

    MISSING
    CONFLICT
    ADDED
    REMOVED
    RESOLVED
    MODIFIED
    UNKNOWN
    IGNORED
    <empty state>

    Or just forget it...

     
  • Oliver Giesen
    Oliver Giesen
    2006-02-10

    Logged In: YES
    user_id=158827

    I think I could live with your proposed ordering, except
    that Unknown and Ignored files would always be less
    important to me than
    regular/up-to-date/controlled/unmodified/whatever files. I
    can see that it looks better if the empty states are at the
    very bottom (or very top) but maybe the real problem here is
    that the state label for those files should not really be empty?

     
  • Kirill Müller
    Kirill Müller
    2006-02-10

    Logged In: YES
    user_id=1241036

    State label for unchanged files: Most files in an WinCvs
    session are unchanged, one usually does not change more
    than a couple of files. So, an empty state label
    indicates "don't worry, no attention needed here". If the
    label said something like "Unchanged", it would distract
    the user's attention -- there are so many unchanged files.
    I'd agree to insert something like "-" or "=" instead of an
    empty label.

    Unknown files: Here, I'd rather agree to Jerzy's comment --
    "should be either added or ignored". A properly set
    up .cvsignore file should be in every directory, I think.

    Ignored files: I agree that they usually are even less
    important than unchanged files. But a user could get
    confused with a sort order where there comes something
    after the empty label. There is that special button "Hide
    ignored files" that does a better job. Maybe we can change
    the empty label to something unimpressive and then list the
    ignored files at the bottom?

     
  • Kirill Müller
    Kirill Müller
    2006-02-10

    Logged In: YES
    user_id=1241036

    Even another idea:

    - Make the icon at the left from the file name reside in an
    own column
    - Sort order for that new column is according to importance
    - Alphabetical sort order for State column

    ?

     
    • milestone: --> WinCvs
    • status: open-postponed --> open-accepted
     
  • Logged In: YES
    user_id=119527

    OK, I think I kinda like the idea of having a checkbox to
    alternate between alphabetical and "improved" order. Let's
    put the checkbox in the "Globals" of preferences under the
    "Match path case with Entries case" and give it the title
    "Smart Sorting" so that we can use it for some other column
    as well (maybe Revision can be improved a bit too...). The
    default should be "turned off" for now and we will wait for
    the feedback. Your suggested order is OK - add the
    description in the help tooltip to specify the order.
    Depending on the feedback we can adjust it later.

     
  • Kirill Müller
    Kirill Müller
    2006-02-11

    Logged In: YES
    user_id=1241036

    Sat Feb 11 2006 Kirill Müller <mail@kirill-mueller.de>
    * WinCvs 2.0.3
    - "Preferences" dialog, "Global" tab:
    Checkbox "smart sorting"
    - Applied patch #1167009: Improved sort order for
    State column -- enabled only if checkbox "Smart sorting" in
    global preferences is set

     
  • Kirill Müller
    Kirill Müller
    2006-02-11

    • assigned_to: jerzyk --> kirillmueller
    • status: open-accepted --> closed-fixed
     
  • Oliver Giesen
    Oliver Giesen
    2006-02-13

    Logged In: YES
    user_id=158827

    Hmm, I would actually have preferred the approach of making
    the icon column sortable and apply the logic there while
    retaining the alphabetical order in the State column...
    Anyway, I'll just give the smart sorting a try and see if I
    like it. ;)