Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#5 bad From: headers generated

closed-accepted
None
5
2002-07-31
2002-07-04
Sjoerd Mullender
No

My password file entry contains comma separated fields
with name, office number, office phone, etc. Syncmail
puts all of this in the From: header, and this confuses
the MTA.

A patch is included which does two things: it strips
off everything after the first comma, and it quotes the
result in double quotes.

Discussion

  • patch

     
    Attachments
  • Logged In: YES
    user_id=43607

    Assigned to a random person so that maybe this gets some
    attention. :-)

     
    • assigned_to: nobody --> fdrake
     
    • status: open --> pending
     
  • Logged In: YES
    user_id=3066

    Why do you remove everything starting with the first comma,
    *and* quote the result? We should be able to just quote the
    result.

     
  • Logged In: YES
    user_id=43607

    Because I don't want my home phone number included in the
    From line.
    The etc. in my original report refers to that. :-)
    Of course, quoting the result is essential since it may
    contain periods which are not allowed unquoted.

     
    • status: pending --> open
     
    • status: open --> closed-accepted
     
  • Logged In: YES
    user_id=3066

    What, you think we're paid to actually read the bug reports?
    ;-)

    I've committed your suggested change as syncmail 1.19. The
    result includes some people losing part of the name if it
    includes a comma (like mine). But that's better than
    exposing phone numbers.