#29 cssed-tags-plugin 0.2 fails to compile

0.4.0
closed-out-of-date
Iago Rubio
5
2005-12-30
2005-12-22
No

On Mac OS X cssed-tags-plugin v.0.2 fails to compile.

There are three problems:

1 - A missing #include <string.h> in callbacks.c which generates those
warnings:

callbacks.c: In function 'on_tp_button_open_tag_file_clicked':
callbacks.c:67: warning: incompatible implicit declaration of built-in
function 'strlen'
callbacks.c: In function 'on_tp_button_query_find_clicked':
callbacks.c:96: warning: incompatible implicit declaration of built-in
function 'strlen'
callbacks.c: In function 'on_tp_button_query_show_all_clicked':
callbacks.c:153: warning: incompatible implicit declaration of built-in
function 'strlen'
callbacks.c: In function 'on_tp_button_open_base_dir_clicked':
callbacks.c:244: warning: incompatible implicit declaration of built-in
function 'strlen'
callbacks.c: In function 'on_tp_create_tag_okbutton_clicked':
callbacks.c:331: warning: incompatible implicit declaration of built-in
function 'strlen'
callbacks.c: In function 'on_tp_create_tag_pushbutton_clicked':
callbacks.c:419: warning: incompatible implicit declaration of built-in
function 'strlen'
callbacks.c: In function 'on_tp_popmenu_goto_tag_activate':
callbacks.c:513: warning: incompatible implicit declaration of built-in
function 'strlen'

Attached is a patch for it.

2 - A missing cast:

interface.c: In function 'create_tag_plugin_pop_menu_entry':
interface.c:424: warning: assignment makes pointer from integer
without a cast

3 - Parse error in the cssed header:

In file included from callbacks.c:29:
/sw/include/cssed/document.h:139: error: parse error before
'CssedFileType'
/sw/include/cssed/document.h:143: error: parse error before '*' token
/sw/include/cssed/document.h:144: warning: data definition has no
type or storage class
/sw/include/cssed/document.h:146: error: parse error before '*' token
/sw/include/cssed/document.h:147: warning: data definition has no
type or storage class

Discussion

  • Patch for missing #include <string.h>

     
  • Iago Rubio
    Iago Rubio
    2005-12-23

    Logged In: YES
    user_id=910507

    > 1.- A missing #include <string.h> in callbacks.c which
    > generates those warnings:

    This is already fixed in cvs.

    #if defined(BSD) || defined(DARWIN)
    #include <string.h>
    #include <errno.h>
    #endif

    > 2 - A missing cast:

    This is not a mising cast, but a missing type. This may be
    produced by 3.

    > 3 - Parse error in the cssed header:
    > In file included from callbacks.c:29:
    > /sw/include/cssed/document.h:139:

    This is not a parse error itself, but again a missing type.
    The compiler does not recognize CssedFileType as an object.
    In fact it's using document.h and it should not use it as it
    was deprecated and new plugins don't use those functions.

    All those problems ought to be fixed in cvs.

    I'm wondering about to bump a new release instead of having
    you patching so heavily the old one.

    What do you think about that ?

     
  • Iago Rubio
    Iago Rubio
    2005-12-23

    • status: open --> pending-out-of-date
     
    • status: pending-out-of-date --> open-out-of-date
     
  • Logged In: YES
    user_id=552580

    Is cvs ok now, you said it was broken?

    If it is ok now, I'll try it. Correct what should be, for example, copyright,
    readme, version, po files, etc...

    Then I test it, tell you if everything's ok, then you can make a new release.

    Is that plan ok for you (it's better than making a new release and thereafter
    discover that something is wrong)?

     
  • Iago Rubio
    Iago Rubio
    2005-12-24

    Logged In: YES
    user_id=910507

    > Is cvs ok now, you said it was broken?

    It should be updated now. If it's still broken then there're
    bugs as the cvs tree is synched right now.

    > If it is ok now, I'll try it.

    Please do it, thanks.

    > Then I test it, tell you if everything's ok, then
    > you can make a new release.
    > Is that plan ok for you

    That's just perfect for me.

    I'll leave out changes on cssed meanwhile you do your tests,
    and won't commit anything but the bugs you reported.

    This will avoid clashes when you commit changes or report bugs.

     
  • Iago Rubio
    Iago Rubio
    2005-12-30

    Logged In: YES
    user_id=910507

    This is fixed, isn't it ?

    If not please re-open the bug :)

    Thanks !!

     
  • Iago Rubio
    Iago Rubio
    2005-12-30

    • status: open-out-of-date --> closed-out-of-date