#24 cssed-filebrowser-plugin fails to compile

0.4.0
closed-fixed
Iago Rubio
5
2006-12-27
2005-12-21
No

There is an assumption in the configure.in file that plugin.h is installed in
prefix/share/cssed

That's plenty wrong on Mac OS X, where headers should be included in
prefix/include/cssed according to Fink policy.

So, we need a test here to go to the correct directory.

Discussion

1 2 3 > >> (Page 1 of 3)
  • Iago Rubio
    Iago Rubio
    2005-12-22

    • status: open --> pending-accepted
     
  • Iago Rubio
    Iago Rubio
    2005-12-22

    Logged In: YES
    user_id=910507

    This have been reported in other platforms as well, and it's
    being fixed, the incoming cssed package changes this.

    Those changes on the main package have been commited to cvs
    but the plugins' packages have not been updated yet.

    I must push the changes on the plugins to cvs, as in this
    state the cvs is broken - plugins can't build.

    I'll do it soon.

     
    • status: pending-accepted --> open-accepted
     
  • Logged In: YES
    user_id=552580

    Did you push the changes now?

    Anyway, I've tried cssed from cvs.

    It does not build as is as there is a cs language in the Makefile, whose po file
    is not installed in the po directory, hence the build fails at the end. Removing
    the cs language in the Makefile and updating the pot and po files to latest
    changes makes it compile.

    As far as cssed-file-browser-plugin from cvs is concerned, a patch in the
    Makefile to the right include dir is not sufficient. It fails miserably with:

    callbacks.c: In function 'on_fb_treeview_files_drag_data_get':
    callbacks.c:447: warning: pointer targets in passing argument 4 of
    'gtk_selection_data_set' differ in signedness
    callbacks.c: In function 'fb_treeview_rename_selection':
    callbacks.c:580: error: parse error before 'cannot_msg'
    callbacks.c:587: error: parse error before '}' token
    callbacks.c: In function 'fb_treeview_create_dir':
    callbacks.c:759: error: parse error before 'g_file_test'
    callbacks.c: At top level:
    callbacks.c:765: error: parse error before 'if'
    callbacks.c:776: warning: parameter names (without types) in function
    declaration
    callbacks.c:776: error: conflicting types for 'g_free'
    /Volumes/FireWire3/sw/include/glib-2.0/glib/gmem.h:52: error: previous
    declaration of 'g_free' was here
    callbacks.c:776: warning: data definition has no type or storage class
    callbacks.c:777: error: parse error before '}' token

     
  • Iago Rubio
    Iago Rubio
    2005-12-24

    Logged In: YES
    user_id=910507

    > Did you push the changes now?

    I've just done that now, please try again.

    Remember to rebuild your configure script and Makefiles.

    First make and install cssed from cvs as well, then try it
    out with the cvs plugins.

    If something fails please let me know.

     
  • Logged In: YES
    user_id=552580

    That's exactly the same as before, even if I run automake and autoconf.

    I cannot see any change in cvs for cssed-filebrowser-plugin.

    Did you really change something today? I can only see the changes for cssed you
    made 5 hours ago.

     
  • Iago Rubio
    Iago Rubio
    2005-12-26

    • status: open-accepted --> open-fixed
     
  • Iago Rubio
    Iago Rubio
    2005-12-26

    Logged In: YES
    user_id=910507

    That's fixed now, this files was outdated/broken.

    Please try it again.

     
  • Logged In: YES
    user_id=552580

    The parse errors have vanished, but the signess error is still here as well as the
    error message when creating a new directory, though the directory is creeated.

    callbacks.c: In function 'on_fb_treeview_files_drag_data_get':
    callbacks.c:447: warning: pointer targets in passing argument 4 of
    'gtk_selection_data_set' differ in signedness

     
  • Iago Rubio
    Iago Rubio
    2005-12-30

    Logged In: YES
    user_id=910507

    That's fixed now in CVS, thanks.

     
1 2 3 > >> (Page 1 of 3)