#60 Patch to make it work on GNU/Hurd

open
nobody
None
5
2012-12-29
2006-04-09
Alfredo Beaumont
No

SA_SIGINFO is not defined in GNU/Hurd, so sigaction
has been changed not to use it, since it doesn't take
advangate of that use anyway.

Discussion

  • Logged In: YES
    user_id=27517

    Patch didn't attach. You have to remember to tick that
    "Attach file" box. Without that, it's hard to judge what
    you mean by "doesn't take advantage of it". That snippet
    is necessary for some platforms to make their curses library
    survive SIGWINCH. Without it, cscope would just hang itself
    if the xterm size is changed.

     
  •  
    Attachments
  • Logged In: YES
    user_id=620211

    Sorry, I forgot to tick the option. Here it goes now.

     
  • Logged In: YES
    user_id=27517

    I'm worried by this patch. Fixing SIGWINCH is tricky
    business --- the difference between an registering an action
    and actually handling the signal may very well be what makes
    the whole fix work in the first place.

    As to HURD not having SA_SIGINFO: given that this is a
    standardized feature of sigaction() (per SUS v3), I tend to
    view that as a bug in HURD, not in cscope. Unconditionally
    disabling cscope's usage of it is thus out of the question.