#787 special characters have inconsistent handling between dialogs

1.72.0
closed
Kevin Zheng
server (358)
5
2014-07-16
2014-06-15
SilverNexus
No

I was experimenting with the special characters in the client (actually trying to see what ones work for reference) and noticed something:

Having a password like "a`duck" (with the grave as the second character) only works on certain windows. The account creation window and the account login window allowed it, but the change password window did not like it (it would not let me change the password to something I've tested to work, such as abc123 [not secure, but sure to work]). So, if a player makes a password with special characters like that, they may lose the ability to ever change it.

Discussion

  • Kevin Zheng
    Kevin Zheng
    2014-06-15

    I was only glancing at the source, but it seems that it actually may be server code at fault.

     
  • Kevin Zheng
    Kevin Zheng
    2014-06-15

    Simple workaround: enter a completely valid but otherwise incorrect password in the "old password" box!

     
  • Kevin Zheng
    Kevin Zheng
    2014-06-15

    • status: open --> analyzed
    • assigned_to: Kevin Zheng
     
  • Kevin Zheng
    Kevin Zheng
    2014-06-15

    • labels: client --> server
    • status: analyzed --> patched
     
  • Kevin Zheng
    Kevin Zheng
    2014-06-15

    Fix committed in r19559. The server was inverting the password checking logic, which meant that as long as you entered your correct current password it would reject it.

     
  • Kevin Zheng
    Kevin Zheng
    2014-07-16

    • status: patched --> closed
     
  • Kevin Zheng
    Kevin Zheng
    2014-07-16

    No response from submitter in a month, so I'll assume the problem has been fixed. Please re-open this bug if it hasn't.