Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#786 Use of command textbox before server selection causes client hang.

1.72.0
feedback-needed
Kevin Zheng
client (4)
5
2014-07-24
2014-06-13
SilverNexus
No

This is similar to bug #782 in the end result and point of occurrence (server selection screen causes a client hang when abnormal commands are attempted), but involves the command textbox instead of the "Quit Character" menu option.

Because of the similarities, I'm beginning to think that the client is sending a message to nowhere (or failing to send it), and then waiting for a response, which it will never get.

Discussion

  • Kevin Zheng
    Kevin Zheng
    2014-06-15

    I believe this is the case. A workaround (and perhaps good fix) would be to hide the main client window until the user has actually logged in.

     
  • Kevin Zheng
    Kevin Zheng
    2014-07-16

    • status: open --> feedback-needed
    • assigned_to: Kevin Zheng
     
  • Kevin Zheng
    Kevin Zheng
    2014-07-16

    I think the best solution is to hide the main window unless the player is actually playing; any suggestions or objections?

     
  • Mark Wedel
    Mark Wedel
    2014-07-17

    I suppose it depends on what is meant by hiding the main window - I generally find applications that raise, lower, or move windows to be on the annoying side.

    However, if the client was instead to gray out/make the main window inactive, I'd probably be OK with that. IRC, there are ways in GTK to make widgets inactive, and I think if that is done for the top level, all children get the same state.

    Though actual cause of the bug should probably be investigated - the client itself should never hang waiting for a response from a server, so more likely what is happening here is that the client is trying to send something to an invalid file descriptor which may be blocking or generating an error that is not properly handled.

     
  • Kevin Zheng
    Kevin Zheng
    2014-07-24

    I was thinking of how Freeciv handles a similar problem: when you start you have a screen to select local or public game, then it goes to a server list, and the finally the main game window. I believe (but haven't checked) it uses the same window, but resizes and repopulates it when necessary.