Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#9 Underscores aren't accepted in the thermal zone names.

open
nobody
None
5
2008-12-03
2008-12-03
Anonymous
No

After upgrading my kernel from 2.6.19 to 2.6.25, I've found that cpufreqd wasn't adjusting the CPU speed correctly, based on the CPU temperature. After some debugging I found that I needed to specify the thermal zone name to the acpi_temperature parameter (I can give more details on this).

When I did it, I got errors:

cpufreqd: plugin_handle_keyword : acpi is unable to parse this value "thermal_zone0:60-100". Discarded

After some digging I noticed that, in the function acpi_temperature_parse there's a sscanf() with the format "%32[a-zA-Z0-9]:%d-%d", and I thought that adding an underscore to the allowed characters, my problem would dissappear. I did, and now I get the expected behaviour again, so the problem is fixed.

Nevertheless, the fact that google knows nothing about this surprises me, since I *think* it's the kernel who gives this name to the thermal zones (drivers/acpi/thermal.c #defines ACPI_THERMAL_CLASS to be "thermal_zone"), so many people should have noticed this before me.

My email is at gmail ("dserrano5").

Discussion