#161 double click on a failure in test dialog does nothing

1.10.2
closed-accepted
5
2006-06-29
2006-05-31
anbey
No

Double click on an failed test in the list control
should invoke the correct source file and source line
in DevStudio via the Testrunner Add-in but - on my
computer - nothing happens.
The reason is the "dirty hack" in method
MsDevCallerListCtrl::OnDblclk in order to get the index
of the selected item.

Instead of:
---------------------------------------
CPoint pt;
UINT flags = 0;
CString lineNumber, fileName;

GetCursorPos( &pt);
ScreenToClient( &pt);

// some dirty hack to get some selection
// should get the border-width + 1, but WINDOWINFO
// is not supported in Win95
pt.x = 5;

hotItem = HitTest( pt, &flags);
---------------------------------------

this works fine at my site:
---------------------------------------
CString lineNumber, fileName;

// get index of selected item
POSITION pos = GetFirstSelectedItemPosition();
hotItem = GetNextSelectedItem(pos);

lineNumber = GetItemText( hotItem,m_lineNumberSubItem);
fileName = GetItemText( hotItem, m_fileNameSubItem);
---------------------------------------
This snippet may be used in code of current 1.11.6, too.

Discussion

  • Logged In: YES
    user_id=196852

    Thanks for providing the correction. It's now committed.

    Baptiste.

     
    • status: open --> closed-accepted