#150 UNICODE Builds not supported

1.11.0
closed-fixed
5
2007-01-27
2005-09-17
Carsten
No

In UNICODE builds the interface to cppunit should take
std:wstring as parameters.

When trying to compile cppunit under MSVC 7 with the
UNICODE characterset, the following files report errors:

Win32DynamicLibraryManager:

DynamicLibraryManager::doLoadLibrary( const std::string
&libraryName )
{
return ::LoadLibrary( libraryName.c_str() );
}

either the library's interface changes to wstring or
this line needs to be updated to

DynamicLibraryManager::doLoadLibrary( const std::string
&libraryName )
{
return ::LoadLibraryA( libraryName.c_str() );
}

The cdxCDynamic* components occasionally pass in a ""
constant as a default parameter to functions that
require a LPCTSTR. This breaks in a UNICODE build and
should be updated to _T("").

If I do this manually, everything seems to work fine.

Discussion

    • status: open --> open-remind
     
    • labels: --> VC++ - Compilation
    • assigned_to: nobody --> blep
     
  • Logged In: YES
    user_id=196852

    Would you mind posting a patch (or the modified files) that
    fix the issue?

    Thanks,
    Baptiste.

     
  • Steven Robbins
    Steven Robbins
    2007-01-27

    Vincent Rivière's patch

     
    Attachments
  • Steven Robbins
    Steven Robbins
    2007-01-27

    Logged In: YES
    user_id=130415
    Originator: NO

    File Added: unicode.diff

     
  • Steven Robbins
    Steven Robbins
    2007-01-27

    Logged In: YES
    user_id=130415
    Originator: NO

    Applied Vincent's patch; fix will appear in 1.12.1.

     
  • Steven Robbins
    Steven Robbins
    2007-01-27

    • status: open-remind --> closed-fixed