Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#24 Attempt to fix [ 1562902 ] and better dual-monitor behaviour

open
nobody
None
5
2014-08-19
2008-02-09
Kirill
No

The patch addresses two bugs:
- [ 1562902 ] Window resizing works funny
- when dragging the Console from one monitor to another, the window ends up at a wrong location.

Both bugs appear only if "Snap to edges" setting is active.

The first bug is caused by a simple mistake in OnWindowPosChanging - you cannot mix GetWindowRect with pWinPos (as in pWinPos->x + rectWindow.Widht()).

The second bug is caused by an attempt to choose which monitor to use in determining edges by using a mouse cursor and moving the main window to that location.

The patch also attempts to improve visual feedback during resizing by jumping the drag rectangle to possible borders (determined by the used font).

Discussion

  • Kirill
    Kirill
    2008-02-09

    first attempt to fix 1562902

     
  • Kirill
    Kirill
    2008-03-29

    Logged In: YES
    user_id=1664805
    Originator: YES

    The new patch is applicable to b139.

    Please, note that I could have lost the following line in MainFrame.cpp:

    if (m_activeView.get() != NULL) m_activeView->SetResizing(true);

    Also note that I could not build the resulting tree because I use VS2005. Sorry.
    File Added: window-resizing-works-better-b139.patch

     
  • Kirill
    Kirill
    2008-04-05

    Files changed in b138+1927612 to implement the patch

     
    Attachments
  • Kirill
    Kirill
    2008-04-05

    Logged In: YES
    user_id=1664805
    Originator: YES

    On a time-line, the resizing.zip follows ole-dnd.zip from 1927612.
    File Added: resizing.zip

     
  • Kirill
    Kirill
    2011-02-13

    Current version is available on github.com/akirill/console

     
  • Kirill
    Kirill
    2011-02-13

    • status: open --> closed-out-of-date
     
  • Kirill
    Kirill
    2011-02-13

    • status: closed-out-of-date --> open
     
  • Kirill
    Kirill
    2011-02-13

    Actually, it's not.