#332 transparency of wallpaper doesn't stay current w/wallpaper c

closed-fixed
Kirill
7
2010-10-29
2009-12-31
Athena
No

Great product, BTW. :-) I have my background on my tabs set to show my desktop (great feature!), but my desktops change every 20 minutes or so -- then my console windows no longer match the background.

Is there anyway to detect the background changing and update the stored bitmap for the tab's transparency?

thanks,
-l

Discussion

  • Hm, Console2 handles this from build 130. Are you sure you're using the latest Console2 build (145)?

    If you are, could you give me more details (windows version, etc) and attach your config file here?

     
  • Athena
    Athena
    2010-01-01

    Console XML config file

     
    Attachments
  • Athena
    Athena
    2010-01-01

    Windows 7Ultimate, 64bit.
    My background is set to display a particular image file. That file is updated periodically, which changes the background.

     
  • Kirill
    Kirill
    2010-02-06

    Marko,

    it was broken by http://github.com/bozho/console/commit/b8176836447d5097e4b406c9c6dc0c961619d26f#L2R262

    and it looks like

    diff --git a/Console/MainFrame.cpp b/Console/MainFrame.cpp
    index 7af436c..5af0324 100644
    --- a/Console/MainFrame.cpp
    +++ b/Console/MainFrame.cpp
    @@ -786,7 +786,8 @@ LRESULT MainFrame::OnSettingChange(UINT /*uMsg*/, WPARAM /*w if (strArea == L"Windows")
    {
    g_imageHandler->ReloadDesktopImages();
    - m_activeView->Invalidate();
    + // m_activeView->Invalidate();
    + m_activeView->Repaint(true);
    }
    else if (strArea == L"Environment")
    {

    would fix it.

    Athena, please, keep in mind that if your background changer does not notify apps about the change, it will still not work.

    --
    Kirill.

     
  • Athena
    Athena
    2010-02-08

    Well, the app notifies the OS, (which changes the background). Other than that, it expects any apps to be told by the OS that something has changed...(though I don't have the source of the app, so I can't tell by which method it tells the OS).

    It's an older call -- as it converts whatever image it is going to use as a background into a a bitmap. I think some of the newer windows background calls take jpg's directly?...

    So this bug wasn't in my imagination! ...yeay!...I'm not totally bonkers..! :-)

     
  • I wonder when I broke it :-)

    Kirill, should I apply the patch to my master branch, or do you have it committed somewhere and I can merge it with your other patches?

    --
    Marko

     
    • priority: 5 --> 7
     
  • Kirill
    Kirill
    2010-02-12

    • assigned_to: nobody --> akirill
     
  • Kirill
    Kirill
    2010-02-12

    Please, do not forget to copy your console.xml into the same folder where you extracted my build to.

     
  • Athena
    Athena
    2010-10-29

    This is seems to be fixed in the 32bit version of 2.00.146 (running on Win7-64).

    As that's where I reported it will mark it fixed/closed; If that's not 'ok', feel free to change it.

     
  • Athena
    Athena
    2010-10-29

    • status: open --> closed-fixed