#1 Folder name tab title etc.

open
nobody
None
5
2013-10-18
2012-03-09
John Peterson
No

! Tab title is console title if not null, otherwise current folder: command.
! Command separator is : instead of -.
! Use WS_MAXIMIZEBOX because it's a requirement for Windows 7 automatic window arrangement.
+ Alt key toggles menu.
- m_strTitle, SetTitle, OnEditRenameTab because of no or limited use.

Please set author (user) to my name if these ideas are committed (so the commit appear in my Ohloh profile).

Thanks!

Discussion

  • John Peterson
    John Peterson
    2012-04-25

    GitHub compared to SourceForge

    The patch is moved to https://github.com/mirror/console-devel/pull/1 because

    • GitHub is better than SourceForge because it allow
      • editing the first post (to make it clearer)
      • removing posts (to organise messages more clearly)
    • git is easier to use than hg
     
    Last edit: John Peterson 2013-10-18
  • Hi John,

    Sorry for this late review. We are still learning about the possibilities of Source Forge.
    Could you explain us a bit more your patch.
    - What feature it add?
    - What but it solve?

    I have the impression that you have worked on more than one topic.

    Could you split your patch unique feature patches such that we can take individual decisions about its parts?

    Best regards,
    Vivian.

     
  • John,

    You described your patch as:

    ! Tab title is console title if not null, otherwise current folder: command.
    ! Command separator is : instead of -.
    ! Use WS_MAXIMIZEBOX because it's a requirement for Windows 7 automatic window arrangement.
    + Alt key toggles menu.
    - m_strTitle, SetTitle, OnEditRenameTab because of no or limited use.
    

    Maybe could you split into 5 patches, such that we can review them an accept them individually.

    We try to document our changes such that we can explain to Kyril what have been done is that branch such that he can take decision for the main branch.

    If you could justify a bit more the reasons behind your patch that would help to have arguments to push them forward.

    Why you want to be change the behaviour of the tab title?
    How could we make it backward compatible?

    What you want the command separator to be ':' instead of '-'

    What is the benefits of WS_MAXIMIZEBOX ?

    What do you mean by "m_strTitle, SetTitle, OnEditRenameTab because of no or limited use" ?

    Thanks again for your interest for Console-devel and for your patch proposition.
    Best regards,
    Vivian.

    PS: you ask me to set your user for your Ohloh counter, I'm not I know how to do it. Maybe could you drop some explanation such that I do the things correctly :-)

     
  • John,

    I noticed that the part of the patch that toggle the menu bar induce a strange behavior when we we switch from application using the Alt+Tab key sequence.

    In the coming version of Console I will deactivate the patch. If you submit a fix for this problem I will of course try to merge it back in the coming release.

    Best regards,
    Vivian.

     


Anonymous


Cancel   Add attachments