Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#56 exception handling question

closed
Jorg Janke
General (18)
5
2005-01-06
2005-01-06
Kocka
No

Hi!

This patch does not fix any known bug, just testing if
you share my views about exception handling.

best regards,
Kocka

Discussion

  • Kocka
    Kocka
    2005-01-06

     
    Attachments
  • Jorg Janke
    Jorg Janke
    2005-01-06

    Logged In: YES
    user_id=87038

    Thanks - It would be nice to know what it fixed (i.e. what the
    error was). It is not required to close a rs as that is
    automatically closed when closing the (parent) pstmt.

     
  • Jorg Janke
    Jorg Janke
    2005-01-06

    • status: open --> closed
     
  • Kocka
    Kocka
    2005-01-07

    Logged In: YES
    user_id=1191788

    pls ignore it
    Catching Exception is too generic and closing both statement
    and resultset in finally block makes some order. e.g. OOM
    errors wont be cought by the catch block, and the resources
    will be left open.
    Also, I don't know if the process should continue after a
    failed operation.
    It is very likely that it does not cause any errors, but
    theoretocally it could.

     
  • Jorg Janke
    Jorg Janke
    2005-01-07

    Logged In: YES
    user_id=87038

    Yep. In general, we "honor the API" i.e. don't re-throw the
    exception but return "no results".
    We enhanced the error capture and processing with the new
    logging infrastructure as we usually don't get meaningful info
    from the user as they "never did anything".

    We also do not close connections (we recover bad
    connections). Therefore the only thing we need to clean up
    are the statements as they could leave open database
    cursors.