Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#33 Currency Convert

closed-postponed
nobody
None
5
2006-10-08
2006-10-03
Vincent Harcq
No

Must be done at DateAcct and never at DateInvoiced or
DateTrx or ...

To solve that do a recursive search on currencyConvert
through all sources and patch...
Should take 1 hour of work

Discussion

  • Yves Sandfort
    Yves Sandfort
    2006-10-03

    Logged In: YES
    user_id=467647

    Will forward to jorg he needs to look into this issue for
    siteeffects.

     
  • Yves Sandfort
    Yves Sandfort
    2006-10-03

    • assigned_to: nobody --> jjanke
     
  • Jorg Janke
    Jorg Janke
    2006-10-07

    • assigned_to: jjanke --> comdivisionys
    • status: open --> pending
     
  • Jorg Janke
    Jorg Janke
    2006-10-07

    Logged In: YES
    user_id=87038

    I agree, although there are a few exceptions.
    I suggest that you create a list with each modification,
    so that we can apply the change and test it. Example:

    a) Aging.java line 97/98/88 oi.DateInvoiced -> oi.Date
    Acct - RV_OpenItem does not have column DateAcct

    To do the research properly, you will need significantly
    more then one hour. We had a similar situation twice in
    the past .... where a quickfix kept me busy for quite a
    while.

    There are 17 other files to check. The Aging.java is
    fixed - took me 45 minutes, but I am a bit slow ...

     
  • Vincent Harcq
    Vincent Harcq
    2006-10-08

    Logged In: YES
    user_id=125677

    I will come back with a list

     
  • Vincent Harcq
    Vincent Harcq
    2006-10-08

    • status: pending --> open
     
  • Vincent Harcq
    Vincent Harcq
    2006-10-08

    Logged In: YES
    user_id=125677

    List of files to check one by one (i will do that)

    Aging.java
    CalloutPaySelection.java
    Doc_Invoice.java
    Doc_MatchInv.java
    Doc_MatchPO.java
    Doc_Order.java
    Doc_ProjectIssue.java
    InventoryValue.java
    InvoiceNGL.java
    MCashLine.java
    MCost.java
    MInvoice.java
    MPayment.java
    PaySelectionCreateFrom.java
    VAllocation.java
    VCreateFromStatement.java
    VPaySelect.java

     
  • Vincent Harcq
    Vincent Harcq
    2006-10-08

    • status: open --> closed-postponed
     
  • Vincent Harcq
    Vincent Harcq
    2006-10-08

    Logged In: YES
    user_id=125677

    We also need to check all calls to SQLJ refering directly
    convert() and not currencyConvert() (which is the SQL name
    refering to Java convert())

    Then redo the work for base() and currencyBase()

    Then check in SQL (views, functions and procedures)

    Half a day then.

    I close this contribution to make a complete one later.

     
  • Yves Sandfort
    Yves Sandfort
    2006-10-08

    • assigned_to: comdivisionys --> nobody