#46 Toolbar should have tooltips

closed-fixed
Pontus Ekberg
None
5
2006-08-24
2006-08-11
Anonymous
No

This would be pretty easy to add, the only difficulty
is that there are no translatable strings that can be
used here. The ones in the other menus have mnemonics
which don't work in a tooltip. I could make a patch to
add tooltips, but I wouldn't know how to get around
this translatable issue except require duplicate
strings in the pot files without underscores/mnemonics.

Also, I think the order of the arrows on the toolbar
should be changed. It currently is < > |< >|, I think
it would be more practical for it to be |< < > >|. This
is just my opinion. Great program, btw.

Discussion

  • Logged In: NO

    Well, I figured an easy way to do it so I made a patch
    anyway. Hopefully, you'll like it.

    -Steven Sheehy

    --- /home/steven/comix 2006-08-11 00:12:13.000000000 -0500
    +++ comix 2006-08-11 00:11:16.028648000 -0500
    @@ -391,6 +391,31 @@
    self.button_manga = gtk.ToggleToolButton('manga')
    self.toolbutton_lens = gtk.ToggleToolButton('lens')

    + self.button_previous.set_tooltip(self.tooltips,
    + _('_Previous page').replace('_', ''))
    + self.button_next.set_tooltip(self.tooltips,
    + _('_Next page').replace('_', ''))
    + self.button_first.set_tooltip(self.tooltips,
    + _('_First page').replace('_', ''))
    + self.button_last.set_tooltip(self.tooltips,
    + _('_Last page').replace('_', ''))
    + self.button_go.set_tooltip(self.tooltips,
    + _('_Go to page...').replace('_', ''))
    + self.toolbutton_fitscreen.set_tooltip(self.tooltips,
    + _('Fit-to-_screen mode').replace('_', ''))
    + self.toolbutton_fitwidth.set_tooltip(self.tooltips,
    + _('Fit _width mode').replace('_', ''))
    + self.toolbutton_fitheight.set_tooltip(self.tooltips,
    + _('Fit _height mode').replace('_', ''))
    + self.toolbutton_fitnone.set_tooltip(self.tooltips,
    + _('Manual zoom mode').replace('_', ''))
    + self.button_double_page.set_tooltip(self.tooltips,
    + _('_Double page mode').replace('_', ''))
    + self.button_manga.set_tooltip(self.tooltips,
    + _('_Manga mode').replace('_', ''))
    + self.toolbutton_lens.set_tooltip(self.tooltips,
    + _('Magnifying _lens').replace('_', ''))
    +
    self.button_previous.connect_object("clicked",
    self.previous_page,
    None)
    self.toolbar.insert(self.button_previous, -1)

     
  • Logged In: NO

    Sourceforge seems to have messed up the new lines on the
    patch. Here's an external link to the patch instead:
    http://pastebin.ca/raw/126146

     
  • Pontus Ekberg
    Pontus Ekberg
    2006-08-11

    Logged In: YES
    user_id=1250348

    Hi there,

    thanks for your tips. Tooltips for the toolbar will be
    included in the next version. I'm afraid the .replace('_',
    '') wouldn't work though. Some translations make this
    impossible, in Traditional Chinese for an example,
    translations look like this:

    msgid "_Next page"
    msgstr "下一頁 (_N)"

    Which would create the tooltip "下一頁 (N)". We just have to
    settle by heaping more work on our poor translators. ;-)

    I agree that |< < > >| looks better, it will be changed also.

    /Pontus

     
  • Pontus Ekberg
    Pontus Ekberg
    2006-08-11

    • assigned_to: nobody --> herrekberg
     
  • Pontus Ekberg
    Pontus Ekberg
    2006-08-24

    Logged In: YES
    user_id=1250348

    Fixed as of version 3.5.

     
  • Pontus Ekberg
    Pontus Ekberg
    2006-08-24

    • status: open --> closed-fixed