Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#5 error tolerant open file

open
James Athey
None
5
2012-09-06
2006-04-24
Dennis Lim
No

Many cbz and cbr out there are incorrectly named. for
example book.cbz is accidentally named book.cbr.

In this case, comical will refuse to open the file
until we rename the file. This is tedious. (It'd be
fine if there were only a handful of misnamed file but
is a pain if there's a lot)
Anyway, I did a patch whereby if one file type fails,
it will retry with the other file type. Only if both
zip and rar fails will it issue the error message.

Patch is in the file attached.

Discussion

  • Dennis Lim
    Dennis Lim
    2006-04-24

     
    Attachments
  • Logged In: NO

    Patches should be in the proper form, not an entire source
    file. How else does one determine what you have changed and
    to what code version they should try to apply it to? If
    you're gonna make patches, you should download latest svn
    and use "svn diff" to output the changes you've made.
    -Steven S.

     
  • Dennis Lim
    Dennis Lim
    2006-04-27

    Logged In: YES
    user_id=117202

    I am developing on windows so I don't have svn installed
    yet. Will look into it.
    In the meantime, here is a diff created with CSDiff. I
    believe it is the same format as some traditional unix diff
    tools use.

     
  • Dennis Lim
    Dennis Lim
    2006-04-27

    diff of changes using CSDiff

     
    Attachments
  • Logged In: NO

    It's not really the same, but similar. It's definitely
    better since now I can see what was changed. Since my
    codebase has changes that I made to it, I wouldn't have been
    able to just place your ComicalFrame.cpp inside of it and
    hoped it work. This way I can make the changes myself if
    necessary. Thanks.