[Codestriker-user] Perforce 'describe' style diff broken... and fixed!

[Preston J. <pre...@gm...>]

Hello all,

I encountered an issue when using the Perforce 'describe' style diff
(this is where you supply the changelist number and the diff is
fetched using the p4 command line tool's 'describe' function). Anyways
the fix was easy enough (though it did take a few hours to hunt around
and learn perl) - one of the arguments in the command line was missing
a hyphen:

lib/Codestriker/Repository/Perforce.pm  (line 116 as of version 1.9.10):

 else { # original case with just one tag specified.
       my $tag = $start_tag ne '' ? $start_tag : $end_tag;

       push @args, 'describe';
       push @args, 'du';   ###########  <---  this needs to be '-du'
       push @args, $tag;
   }

The result was that creating a topic would end up having incorrect
diffs as the default perforce diff format is different from the
unified diff spec.

Can someone please submit this fix on my behalf?

Thanks, Preston