#87 When reviewing, "no Line XXX" link available

open
nobody
None
5
2009-03-25
2009-03-24
No

Fresh install of 1.9.8

When reviewing, "no chunk diff" comment link available.
The "Parallel" link and Topic comment is working on both sides though.
The individual line links are also working on both sides.

Discussion

  • No link available

     
    Attachments
  • Snippet of the html, which show that it's mising a bit of html.

    <td class="line" colspan="2">
    Line 1
    |
    <a href="javascript: myOpen('http://codestriker.dev.stw/codestriker/codestriker.pl?action=view_file&fn=0&topic=8531826&new=0&mode=1#0|1|0', 'Codestriker')">
    Parallel
    </a>

    </td>
    <td class="line" colspan="2">
    Line 1
    |
    <a href="javascript: myOpen('http://codestriker.dev.stw/codestriker/codestriker.pl?action=view_file&fn=0&topic=8531826&new=1&mode=1#0|1|1', 'Codestriker')">
    Parallel
    </a>
    </td>
    </tr>

     
  • Sorry I am confused.. what exactly is the problem? Can you give more information?

     
  • Sorry if I wasn't clear enough.
    When doing a codestrike, there's no link to add a comment for the diff block (the Line xxx link, beside the Parallel link).

    The comment links do however work at the topic level (ie: for the whole review), and at the individual line level. Please look at the attachment. "Line 1" isn't underscored as it should be. I've also pasted the relevant html code (using Firefox or Safari).

     
  • The "Line XXX" links have been supported for a few releases now, since the rendering code was massively refactored. At the moment, only Parallel links are supported.

    Do you find the "Line XXX" links useful?

     
  • That is - the line links have "not been supported" for a few releases now.

     
  • It's important enough to maybe rollback to the working version. What's the last version where the line links did work ?

    tia,
    gabB

     
  • David Sitsky
    David Sitsky
    2009-03-25

    • summary: When reviewing, "no chunk diff" comment link available --> When reviewing, "no Line XXX" link available
     
  • David Sitsky
    David Sitsky
    2009-03-25

    You'll need 1.9.4, but I wouldn't recommend it, as I imagine a large number of bugs have been fixed since that release. Can't you just use the Parallel view and use the horizontal scrollbar to position the view appropriately?

     
  • Documentation should be updated to "remove" this feature. The individual line links do work, and this is what we will use, since, as you stated, many bugs were fixed, and major improvments were made, so a rollback is not an option. Thanks for your time.