#73 Add "Reviewer Approves", "Reviewer Disapproves" Buttons

open
nobody
None
5
2007-11-09
2007-11-09
Anonymous
No

It would be useful if a buttons were added so that reviewer could indicate that they have finished a review and whether or not they approve the diffs for commit.

A simple email pop-up similar to the current comment entry pop-ups with a title matching the "approve"/"deny" text would be sufficient.

A more thorough version of this would require preservation of some reviewer states. "Sign up", "submit comments" and then "issue decision".

Discussion

  • Trejkaz
    Trejkaz
    2007-11-14

    Logged In: YES
    user_id=639492
    Originator: NO

    IMO there are three possible states once a review is completed:
    1. Resubmit review after fixing (if the submitted code had major problems)
    2. Acceptable after resolving minor changes (some organisations may omit this and require resubmission even for minor changes)
    3. Acceptable as-is

    Although #3 would be pretty rare I think. Rarer than a dodo.

     
  • Logged In: NO

    You can do something like this, if you add a metric having the state Action with "reviewed, ready to checkin" and "revise"

     
  • Logged In: NO

    this, or just the "reviewer done" button requested earlier would be fabulous. one of the primary complaints about using codestriker in my organization is the lack of the ability to simply say "i'm done" without making any comments.
    (case #3 actually happens a lot for us, bc we have to use codestriker for every single edit, no matter how minor or trivial...)