Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#70 File links at the top point to an ambiguous anchor

closed-fixed
nobody
None
5
2008-03-17
2008-02-08
Trejkaz
No

The links to files at the top of a code review page go to an anchor with the same name as the path to the file.

Problem is, this anchor occurs twice in the HTML -- once at the top, once at the bottom.

Opera happens to choose the bottom one, so clicking on any file link will invariably take me to the bottom of the review for that file. Firefox presumably chooses the top. To remove the ambiguity, the one at the bottom should probably be removed.

Discussion

  • rob_webset
    rob_webset
    2008-02-26

    Logged In: YES
    user_id=1137102
    Originator: NO

    The simplest fix for this is:

    File: Render.pm
    Method: _coloured_mode_finish

    Remove the following code:

    if ($self->{fview} != -1) {
    # Show the current file header again for navigation purposes when
    # viewing a single file at a time.
    $self->delta_file_header($self->{diff_current_filename},
    $self->{diff_current_revision},
    $self->{diff_current_repmatch});
    }

    This would remove the bottom bar at the end of the single file view.

    This would also solve the problem that the top bar spans the whole of the width of the code review, and the bottom one just spans the viewable screen.

     
  • David Sitsky
    David Sitsky
    2008-03-17

    • status: open --> closed-fixed
     
  • David Sitsky
    David Sitsky
    2008-03-17

    Logged In: YES
    user_id=208928
    Originator: NO

    Fixed so only the top anchor is displayed - will be available in the next release.