#54 output from diff for differing binary files chokes recogn

closed-fixed
nobody
None
5
2007-06-29
2007-06-22
mt
No

When there are lines of the form:
Files X and Y differ.
the patch file isn't recognized as a valid patch, and just comes up as a normal. it should do something better, at the best create an entry in the file list indicating differing binary files were found, or at least error out.

Discussion

  • David Sitsky
    David Sitsky
    2007-06-24

    Logged In: YES
    user_id=208928
    Originator: NO

    Yep you are right. Can you attach a sample patch file with the issue so that when I look into this issue, I have an immediate test case? Thanks.

     
  • mt
    mt
    2007-06-25

    Logged In: YES
    user_id=390544
    Originator: YES

    File Added: differing_binaries.patch

     
  • mt
    mt
    2007-06-25

    patch file w/ a "Files xxx and yyy differ" entry.

     
  • David Sitsky
    David Sitsky
    2007-06-29

    Logged In: YES
    user_id=208928
    Originator: NO

    The lib/FileParser/PatchBasicDiff.pm and lib/FileParser/PatchUnidiff.pm modules have been updated to handle this file in CVS. This will appear in the upcoming 1.9.4 release.

     
  • David Sitsky
    David Sitsky
    2007-06-29

    • status: open --> closed-fixed