#42 mod_perl & Subversion Error

closed-fixed
nobody
None
6
2007-07-12
2007-01-24
rob_webset
No

Hi David,

I found the following problem when enabling mod_perl (Apache 2 - Windows) when you create a topic you get an error along the lines of:

open3: Can't close: Bad file descriptor at Subversion.pm

It looks like it doesn't like:

$pid = open3($write_stdin_fh, $read_stdout_fh, $read_stderr_fh,
$Codestriker::svn, @args);

Do you know of a fix for this?

Note: The CGI version works OK.

Thanks

Rob

Discussion

  • rob_webset
    rob_webset
    2007-04-24

    • priority: 5 --> 6
     
  • David Sitsky
    David Sitsky
    2007-07-02

    Logged In: YES
    user_id=208928
    Originator: NO

    I have read the following from http://www.nntp.perl.org/group/perl.inline/2004/04/msg2268.html:

    With ModPerl::Registry (that what it's called with mod_perl 1.99) I get
    issues similar to yours: some handles can't be closed/opened. Basically
    what is happenning is that ModPerl::Registry replaces
    STDIN/STDOUT/STDERR by special objects that are not really file
    descriptors. This breaks Open3.pm which tries to dup these filehandles.

    This is a pain... as open3 is used to read any stderr messages. At least I can reproduce this, but for now, you'll have to use CGI.

     
  • David Sitsky
    David Sitsky
    2007-07-03

    Logged In: YES
    user_id=208928
    Originator: NO

    I've just committed code into CVS which should fix Subversion, at least when clicking on the Parallel links. There is still work to be done for handling topic creation. I had exactly the same error when using CVS, but now it is all working.

    Any chance of you trying this out for me? You'll need to checkout the code from CVS. Failing that, this will appear in the next release.

     
  • rob_webset
    rob_webset
    2007-07-03

    Logged In: YES
    user_id=1137102
    Originator: YES

    Hi David,

    I'll be happy to test this when the next release including the Test Director enhancements go in (https://sourceforge.net/tracker/index.php?func=detail&aid=1643356&group_id=41136&atid=429862) as I'll need that in order to conduct the testing.

    Thanks

    Rob

     
  • David Sitsky
    David Sitsky
    2007-07-03

    Logged In: YES
    user_id=208928
    Originator: NO

    No worries - I'll eventually get to it. I have had a bit of a backlog to work through.

     
  • David Sitsky
    David Sitsky
    2007-07-12

    • status: open --> closed-fixed
     
  • David Sitsky
    David Sitsky
    2007-07-12

    Logged In: YES
    user_id=208928
    Originator: NO

    This has now been tested, fixed and committed into CVS.