Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#41 Duplicate Lines shown when using the parallel viewing option

closed-works-for-me
nobody
None
5
2007-06-29
2006-12-13
Peter Ikin
No

When using the parallel option from the review text window in some cases there appears to be duplication of code lines taking place. The right hand side of the window behaves as expected but the left hand side seems to display the different lines as well as the original code. i.e.

The actual code changes made where as follows:-

Original Line 1
Original Line 2
-- Added Line 1
-- Added Line 2
Original Line 3
Original Line 4

When using the parallel display you would get something similar to the following

LHS -- RHS
Original Line 1 -- Original Line 1
Original Line 2 -- Original Line 2
-- Added Line 1
-- Added Line 2
Original Line 3 -- Original Line 3
Original Line 4 -- Original Line 4
Original Line 2 -- Original Line 2
Original Line 3 -- Original Line 3
Original Line 4 -- Original Line 4

I have only seen this behaviour on one specific review. In general the parallel display appears to function correctly.

Discussion

  • David Sitsky
    David Sitsky
    2006-12-13

    Logged In: YES
    user_id=208928
    Originator: NO

    Sounds very strange. The only way I can fix this is if you send me the diff from the review where this is happening. You can send it to me at sits AT users DOT sourceforge DOT net.

    Cheers,
    David

     
  • David Sitsky
    David Sitsky
    2006-12-14

    Logged In: YES
    user_id=208928
    Originator: NO

    Also - where there any errors in the apache log file as a result of clicking on the parallel link? This might also be helpful to receive.

    The HTML source of the parallel link would also be useful.

    Cheers,
    David

     
  • Peter Ikin
    Peter Ikin
    2006-12-14

    Logged In: YES
    user_id=1667371
    Originator: YES

    Hi David

    I noticed this whilst working on a closed source commercial product so I am unable to provide the diff. From a cursory inspection the diff (from perfoce incidently) looks normal. I also don't have access to the server to get a look at the log file.

    I am going to try and reproduce this problem on my home system with some test code. If this is a problem with codestriker I don't see why I wouldn't be able to replicate the issue with code that is structured similarly.

    I will keep you posted on whether I can reproduce this or not.

    Peter

     
  • Peter Ikin
    Peter Ikin
    2006-12-22

    Logged In: YES
    user_id=1667371
    Originator: YES

    Hi David

    I have seen this behaviour again on a separate review.
    In both cases the problem occurs when the code being added is within a switch statement.
    i.e. the original code contains a switch and the updated code contains the same switch with extra case statements added to it. As I mentioned before this only shows up in the parallel view.

    Hope this helps.

    Peter

     
  • David Sitsky
    David Sitsky
    2007-06-29

    • status: open --> closed-works-for-me
     
  • David Sitsky
    David Sitsky
    2007-06-29

    Logged In: YES
    user_id=208928
    Originator: NO

    Haven't heard anything back, so marking this as unreproducible.