Re: [CLucene-dev] AddIndexesNoOptimize testadded to intensive_testing branch, some problems in core detected

[Kostka B. <ko...@to...>]

> -----Original Message-----
> From: Itamar Syn-Hershko [mailto:it...@co...]
> Sent: Wednesday, September 15, 2010 9:08 PM
> To: clu...@li...
> Subject: Re: [CLucene-dev] AddIndexesNoOptimize testadded to intensive_testing
> branch, some problems in core detected
> 
> On 15/9/2010 1:33 PM, Šplíchal Jiří wrote:
> > Hello,
> >
> > the IndexModifierTest::testIMinsertDelete is working now, the problem seems to be
> the delay between the _unlink call
> > and the time the file is really deleted. I added a new method Misc::file_Unlink() which
> unlinks a file and
> > waits until the dir_Exists method return false and used it in
> FSDirectory::createOutput().
> >
> > Borek figured out that the testAddIndexesNoOptimize::testHangOnClose test is
> working if we switch off
> > the random exceptions in MockRAMDiretory.
> >
> 
> Isn't this cheating?

I don't think so. Test is commented as test for LUCENE-1270 issue, which is not related to any exceptions thrown from
directory. No idea, why MockRAMDirectory is used in test, perhaps because it contains some additional checks.

In Java version of MockRAMDirectory random exceptions are not thrown by default (because randomIOExceptionRate
is set to 0 by Java automatically (0 means no random exception). 

Perhaps the 100% correct way will be to add randomIOExceptionRate = 0. into MockRAMDirectory constructor, so
setRandomIOExceptionRate(0.0, 0) call used in test won't be needed.

Borek

> 
> > I pushed the changes to the repository. Now it seems that all the tests are working
> (except of the testWickedLongTerm).
> > But still they produce a lot of memory leaks.
> >
> I switched testWickedLongTerm off for the time being (in master).
> 
> Itamar.
> 
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> CLucene-developers mailing list
> CLu...@li...
> https://lists.sourceforge.net/lists/listinfo/clucene-developers