#12 Revise arguments on CommandQueue methods

closed
nobody
None
5
2010-08-28
2010-05-04
nythrix
No

CommandQueue methods (Read/Write/Copy) that act on ComputeImages take arrays of longs. 3 element arrays are requested but this requirement isn't checked by Cloo. Solutions:
1) Trade the arrays for separate arguments (long[3] -> long, long, long). Not very elegant since this could push the total argument count on some methods to 10 or more.
2) Introduce structures with 2 and/or 3 elements. Type safety enforced by the compiler.
3) Go further than (2) and introduce a new array of CommandQueue methods that should solve both this issue and https://sourceforge.net/tracker/?func=detail&aid=2992317&group_id=290412&atid=1229017

Discussion

  • nythrix
    nythrix
    2010-05-04

    Condition should be compile-time checkable!
    Otherwise adding a test against the array length is trival.

     
  • nythrix
    nythrix
    2010-08-28

    Implemented as 3) in 0.8.0

     
  • nythrix
    nythrix
    2010-08-28

    • status: open --> closed