Re: [Clonekeenplus-development] [Clonekeenplus-commits] [SCM] clonekeenplus branch, master, updated. 5f86f9eb36686c0a26204411f3bdc7dd72fe1716

[Chad A. <ch...@ne...>]

Hey Gerd,

I'm pretty sure that it used to be called Mode, but when you added the Sounblaster/Adlib Or PC Speaker option, you changed that to be called mode, and changed the channels text in one place but not the other.

I don't think it makes a huge difference as far as the variable names go, but if you want to change them go ahead.

I got it to build finally, and I uploaded it to SourceForge.

Thanks,
Chad

On Jul 10, 2011, at 2:17 PM, Gerhard Stein wrote:

> Hi Chad,
> 
> I don't want to get strict, but quite now I don't get the difference 
> between "Mode:" and "Channels:". "Channels" is better I think as you 
> changed it. Should we also change the variable names?
> 
> Should we even use the word "mode" for something related to Audio?
> 
> Btw. I hope you got the code compiled this time :-)
> 
> Regards,
> Gerd
> 
> Am 10.07.2011 22:00, schrieb Chad Anderson:
>> index a3b0d25..f09fb20 100644
>> --- a/src/common/Menu/CAudioSettings.cpp
>> +++ b/src/common/Menu/CAudioSettings.cpp
>> @@ -138,7 +138,7 @@ void CAudioSettings::processSpecific()
>>  			else if(m_selection == 2)
>>  			{
>>  				m_Mode = !m_Mode;
>> -				buf = "Mode: ";
>> +				buf = "Channels: ";
>>  				buf += m_Mode ? "Stereo" : "Mono";
>>  				mp_Dialog->setObjectText(2, buf);
>>  				m_must_restart_sounddriver |= true;
>> 
>> 
>> hooks/post-receive
> 
> 
> 
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security 
> threats, fraudulent activity, and more. Splunk takes this data and makes 
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Clonekeenplus-development mailing list
> Clo...@li...
> https://lists.sourceforge.net/lists/listinfo/clonekeenplus-development