Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#28 Describe function gives a 404 error

closed-rejected
Sam Steingold
None
5
2008-11-23
2008-11-05
Joe Smith
No

As described in https://bugs.edge.launchpad.net/ubuntu/+source/clisp/+bug/151249

The describe function will first check http://www.lisp.org/HyperSpec/Data/Map_Sym.txt and then http://www.lisp.org/HyperSpec/Data/Symbol-Table.text for a lookup. Redundancy is great, except this leads to a 404 error with the first one at Map_Sym.txt. I ran a grep over the source, and found the code in src/clhs.lisp. I don't think that we should check a page that will always give us a 404 error every time. If this isn't in the right format, or there's something you'd like me to change, please let me know. Thanks guys!

Testcase:
(DESCRIBE 'FORMAT)

Expected:
Return lookup info

Actual:
Gives a 404 from the first page, then checks the second for results.

Index: clhs.lisp

RCS file: /cvsroot/clisp/clisp/src/clhs.lisp,v
retrieving revision 1.56
diff -u -r1.56 clhs.lisp
--- clhs.lisp 24 Sep 2008 16:45:56 -0000 1.56
+++ clhs.lisp 5 Nov 2008 22:37:26 -0000
@@ -257,8 +257,8 @@
(let ((clhs-root (clhs-root)))
(when (and clhs-root (string/= clhs-map-source clhs-root))
(setq clhs-map-source clhs-root)
- (with-open-stream (s (or (open-url (string-concat clhs-root "Data/Map_Sym.txt") :if-does-not-exist nil)
- (open-url (string-concat clhs-root "Data/Symbol-Table.text") :if-does-not-exist nil)))
+ (with-open-stream (s (or (open-url (string-concat clhs-root "Data/Symbol-Table.text") :if-does-not-exist nil)
+ nil))
(unless s
(warn (TEXT "~S returns invalid value ~S, fix it, ~S, ~S, or ~S")
'clhs-root clhs-root '(getenv "CLHSROOT")

Discussion

<< < 1 2 (Page 2 of 2)
  • Joe Smith
    Joe Smith
    2008-11-06

    Alright, I gotcha, I see where it's going now. Thanks for explaining it.

     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
    • status: pending-rejected --> closed-rejected
     
<< < 1 2 (Page 2 of 2)