Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#24 fix cygwin default encoding

closed-rejected
Sam Steingold
None
5
2007-01-30
2007-01-11
Reini Urban
No

src/encoding.d (encoding_from_name) has a wrong cygwin textmount logic:

#if defined(WIN32) || (defined(UNIX) && (O_BINARY != 0))
pushSTACK(S(Kdos)); /* :line-terminator */

not binary => textmount: doseol

Attached patch (with changelog) fixes that. Thanks to Aaron Brown <arundelo@hotmail.com> for finding this.

Discussion

1 2 3 > >> (Page 1 of 3)
  • Reini Urban
    Reini Urban
    2007-01-11

     
    Attachments
  • Sam Steingold
    Sam Steingold
    2007-01-11

    • assigned_to: nobody --> sds
    • status: open --> pending-rejected
     
  • Sam Steingold
    Sam Steingold
    2007-01-11

    Logged In: YES
    user_id=5735
    Originator: NO

    This patch does not seem right.
    on linux O_BINARY==0 and I see no reason to default line termination to :DOS there.
    I am rejecting it pending your convincing me that I am wrong here.

     
  • Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
    • status: pending-rejected --> closed-rejected
     
  • Reini Urban
    Reini Urban
    2007-01-27

    Logged In: YES
    user_id=13755
    Originator: YES

    File Added: cyg-encoding2.patch

     
  • Reini Urban
    Reini Urban
    2007-01-27

    patch fixed

     
    Attachments
  • Reini Urban
    Reini Urban
    2007-01-27

    • status: closed-rejected --> open-rejected
     
  • Reini Urban
    Reini Urban
    2007-01-27

    Logged In: YES
    user_id=13755
    Originator: YES

    Sorry, I thought the UNIX logic applied to CYGWIN only.
    Fixed that in cyg-encoding2.patch to check for WIN32 and __CYGWIN__.

     
  • Sam Steingold
    Sam Steingold
    2007-01-28

    • summary: [PATCH] fix cygwin default encoding --> fix cygwin default encoding
     
1 2 3 > >> (Page 1 of 3)