From: Martin Atzmueller <marty@cs...> - 2000-02-23 02:10:45
On 22 Feb 2000, Sam Steingold wrote:
> please make a patch without reformatting (which I can read), and when it
> is approved, do the reformatting.
> the only acceptable reformatting is
> (if t
> (then clause)
> (else clause))
> etc. no spaces between parens, no paren-only lines.
Ok, I agree. I personally like spaces between parens _sometimes_ if it makes the code more readable.
But the file reploop.lsp _does_ contain paren-only lines and I wanted to get rid of that!
Es ist nicht gesagt das es besser wird wenn es anders wird.
Wenn es aber besser werden soll muss es anders werden.
Going to be different does not necessarily mean getting better.
But getting better _does_ necessarily imply being different.)
-- G. Ch. Lichtenberg
From: Sam Steingold <sds@gn...> - 2000-02-23 15:21:58
>>>> In message <Pine.LNX.4.21.0002221947430.22062-100000@...>
>>>> On the subject of "Re: CLISP patch"
>>>> Sent on Tue Feb 22 21:09:55 EST 2000
>>>> Honorable Martin Atzmueller <marty@...> writes:
>> But the file reploop.lsp _does_ contain paren-only lines and I
>> wanted to get rid of that!
yes, this is the "legacy formatting", and it would be good to get rid of
it. but it decreases the reaability of the patch, so I would prefer, if
it is not too much work, to see the patch with code changes only, but to
have the full changes (translations and reformatting) checked in. I
guess it *is* too much work (at least it would have been for me), so
could you please do it in 4 steps:
1. follow the developer's instructions
and get the source tree. you are a developer, so you have full write
2. modify your patch, removing the extra newline (which I am not sure I
like :-), but keeping the comments translations and reformatting (as
well as the shorter commands &c).
3. check the patch into CVS: you have to check in 2 files:
src/reploop.lsp and src/ChangeLog. Please ask beforehand if you have
any questions about the format of ChangeLog &c.
4. post the extra newline patch to this list. after it is reviewed, you
will check it in.
Thanks, Martin, and welcome again!
Sam Steingold (http://www.podval.org/~sds)
Micros**t is not the answer. Micros**t is a question, and the answer is Linux,
(http://www.linux.org) the choice of the GNU (http://www.gnu.org) generation.
Bus error -- please leave by the rear door.