Re: any button in new-clx grab-button function.

[Sam S. <sd...@gn...>]

> * Philippe Brochard <ub...@se...> [2008-11-04 22:53:09 +0100]:
>
>> while this "too_few" error handling style is enshrined in SEND-EVENT,
>> I think it sucks (and easy to fix, just write
>> DEFUN(XLIB:QUEUE-EVENT, display event-key &rest args)
>> instead, see XLIB:KEYSYM and COPY-GCONTEXT-COMPONENTS).
>> it would be nice if you fixed both your function and SEND-EVENT.
>>
> I haven't found how to use &key and &allow-other-keys so I use the
> open-display method to handle errors. (this needs to make
> error_too_few_args visible from clisp.h). See below if this is
> acceptable.

as I said in the message you quote:
the declaration should be

DEFUN(XLIB:QUEUE-EVENT, display event-key &rest args)

this will take care of the error_too_few_args issue.

> --------------------------------------------------
> cvs diff: Diffing .
> cvs diff: Diffing benchmarks
> cvs diff: Diffing doc
> cvs diff: Diffing emacs
> cvs diff: Diffing modules
> cvs diff: Diffing modules/berkeley-db
> cvs diff: Diffing modules/bindings
> cvs diff: Diffing modules/bindings/glibc
> cvs diff: Diffing modules/bindings/win32
> cvs diff: Diffing modules/clx
> cvs diff: Diffing modules/clx/mit-clx
> cvs diff: Diffing modules/clx/mit-clx/debug
> cvs diff: Diffing modules/clx/mit-clx/demo
> cvs diff: Diffing modules/clx/mit-clx/test
> cvs diff: Diffing modules/clx/new-clx

I suggest

cvs -q -z9
diff -uwp
update -dP

in ~/.cvsrc

thanks for also supplying a ChangeLog entry.

-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 8.04 (hardy)
http://thereligionofpeace.com http://palestinefacts.org
http://truepeace.org http://iris.org.il http://openvotingconsortium.org
My other CAR is a CDR.