the "Argument cannot be null" i think if on my plate w/ the gui builder. i will fix this monday morning. basically it occurs when you call guibuilder from the gui thread...

w/ the data validator, are you putting both algorithmfactory and datavalidators as its interfaces in the component.xml?

bruce

On 9/30/06, Ben Markines <bmarkine@cs.indiana.edu> wrote:
Some things that I think may be wrong:

I don't think the FileLoad is setting the property AlgorithmProperty.LABEL for the data 'model'.  It is null during the save.

When I execute:
         String message = "The file:\n" + file.getPath() + "\nalready exists. Are you sure you want to overwrite it?";
         return guiBuilder.showConfirm("File Overwrite", message, message);

It throws a ' java.lang.IllegalArgumentException : Argument cannot be null'.  I might be using the guiBuilder incorrectly because showInformation() is giving me the same error.  This also might be a result of a missing plugin?

Save will be printing to log as long as this error shows up.

Also I have implemented DataValidator, and tried adding
        <provide interface=
            "org.cishell.framework.algorithm.DataValidator"/>
to save.xml, but am still not receiving a call to validate... how am I supposed to register the class to receive these notifications?

The checked in code has the following fixes for:
* File/Save should start off with a suggested name like: data.$EXTENSION_USED or $THE_LABEL_OF_THE_DATA.
$EXTENSION_USED
* File/Save using the nwb persister isn't actually saving where i tell it to. I loaded w/ the file/load then after that went file/save, chose where to save it, and it wasn't saved there.

Regards,
Ben


On 9/29/06, Weixia(Bonnie) Huang < huangb@indiana.edu> wrote:

I have fixed all items in File Load implementation and commit the code. Let me know if you find more problems needed to be fixed before Monday release.

 

Thanks,

-Bonnie

 

From: bherr2@gmail.com [mailto:bherr2@gmail.com] On Behalf Of Bruce Herr
Sent: Thursday, September 28, 2006 6:51 PM
To: Weixia(Bonnie) Huang; Ben Markines; cishell-developers@lists.sourceforge.net
Subject: persistence plugin changes to make

 

Ben and Bonnie,

I looked over the persistence plugin. I made a couple fixes on some minor things (moved load and save to the start group of the File menu, added OSGI-INF to build.properties...).

Here are some minor things i'd like you to do:
* I have committed the new gui builder (and updated plugins to use it). Please update the load and save plugins so that errors are popped up to the user rather than on the console log when loading/saving.
* Get rid of some debugging messages that are printed to system.out
* nwb persisters should use file-ext:nwb NOT file-ext:.(dot)nwb
* File/Save should also extend DataValidator and make itself clickable only when the selected datamodel(s) can possibly be saved (must have at least one converter)
* File/Save should start off with a suggested name like: data.$EXTENSION_USED or $THE_LABEL_OF_THE_DATA.$EXTENSION_USED
* File/Save using the nwb persister isn't actually saving where i tell it to. I loaded w/ the file/load then after that went file/save, chose where to save it, and it wasn't saved there.

Other related things:
* We will need to make converters that will hook in file:text/nwb data too (what santo outputs). This may mean we need 4 converters (file:text/nwb->file-ext:nwb, file-ext:nwb->file:text/nwb, file:text/nwb-> java.blah.NWBModel, java.blah.NWBModel->file:text/nwb). We will need less once we get multi-step conversions going.
* edu.iu.nwb.converters isn't compiling...
* Please email the developer list with any other bugs/things we need to fix so that we can get them done.

One final thing,
>From here on out, ALL developer talk should be done through cishell-developers@lists.sourceforge.net so that outsiders can see what we are up to and possibly join in discussions as well.

Bruce